Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2688] Add loading indicator and details when no items #2345

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[DUOS-2688] Add loading indicator and details when no items #2345

merged 1 commit into from
Oct 4, 2023

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2688

Summary

Adds a loading indicator and shows 'No datasets registered for this Library' if there are no results to display.

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner October 2, 2023 20:38
@fboulnois fboulnois changed the title Add loading indicator and details when no items [DUOS-2688] Add loading indicator and details when no items Oct 2, 2023
rushtong
rushtong approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

hams7504
hams7504 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@fboulnois fboulnois merged commit 89a1686 into develop Oct 4, 2023
10 checks passed
@fboulnois fboulnois deleted the fb-duos-2688-no-studies-view branch October 4, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hams7504 hams7504 hams7504 approved these changes

@rushtong rushtong rushtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fboulnois @rushtong @hams7504