Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2712] UI Improvements to Translator Tool Page #2353

Merged
merged 3 commits into from
Oct 13, 2023
Merged

[DUOS-2712] UI Improvements to Translator Tool Page #2353

merged 3 commits into from
Oct 13, 2023

Conversation

hams7504
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2712

Summary

  • Restyled the button
  • Renamed the page
  • Removed unnecessary text

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@hams7504 hams7504 marked this pull request as ready for review October 13, 2023 13:40
@hams7504 hams7504 requested a review from a team as a code owner October 13, 2023 13:40
rushtong
rushtong approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

fboulnois
fboulnois approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanups lgtm 👍

@hams7504 hams7504 merged commit aada29d into develop Oct 13, 2023
10 checks passed
@hams7504 hams7504 deleted the hm-duos-2712-ui-improvements branch October 13, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fboulnois fboulnois fboulnois approved these changes

@rushtong rushtong rushtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hams7504 @rushtong @fboulnois