Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2714] Add external access to data submission form #2359

Merged
merged 2 commits into from
Oct 31, 2023
Merged

[DUOS-2714] Add external access to data submission form #2359

merged 2 commits into from
Oct 31, 2023

Conversation

fboulnois
Copy link
Contributor

@fboulnois fboulnois commented Oct 18, 2023 •
edited
Loading

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2714

Summary

Refactor the UI so that open access and external access are their own radio button options separate from primary data use.

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner October 18, 2023 20:29
hams7504
hams7504 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@fboulnois fboulnois force-pushed the fb-duos-2714-external-access-submission branch from 374eb39 to d5a29b2 Compare October 30, 2023 14:37
@fboulnois fboulnois force-pushed the fb-duos-2714-external-access-submission branch from d5a29b2 to a096fc0 Compare October 30, 2023 14:43
rushtong
rushtong approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

rushtong
rushtong approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois merged commit f8b1abf into develop Oct 31, 2023
@fboulnois fboulnois deleted the fb-duos-2714-external-access-submission branch October 31, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushtong rushtong rushtong approved these changes

@hams7504 hams7504 hams7504 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fboulnois @rushtong @hams7504