Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2745][risk=no] Fix SO display in profile #2360

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Oct 19, 2023

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2745

Summary

Fixes the call to get the SOs for a user

Before:

Screenshot 2023-10-19 at 8 32 54 AM

After:

Screenshot 2023-10-19 at 8 32 43 AM

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner October 19, 2023 12:31
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@rushtong rushtong merged commit bc70648 into develop Oct 19, 2023
10 checks passed
@rushtong rushtong deleted the gr-DUOS-2745-fix-sos branch October 19, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants