Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2738][risk=no] Bug fix for roles allowed #2367

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[DUOS-2738][risk=no] Bug fix for roles allowed #2367

merged 1 commit into from
Oct 24, 2023

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Oct 24, 2023 •
edited
Loading

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2738

Summary

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner October 24, 2023 20:39
fboulnois
fboulnois approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops good catch 👍

@rushtong rushtong merged commit ec0d9e0 into develop Oct 24, 2023
10 checks passed
@rushtong rushtong deleted the gr-DUOS-2749-bug-fix branch October 24, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hams7504 hams7504 hams7504 approved these changes

@fboulnois fboulnois fboulnois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushtong @fboulnois @hams7504