Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2757] Increase first column width in study and dataset tables #2400

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

hams7504
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2757

Summary

Screenshot 2023-11-15 at 2 42 24 PM

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@hams7504 hams7504 requested a review from a team as a code owner November 15, 2023 19:42
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CollapsibleTable component should be general purpose, so this fixes it for the data library at the cost of breaking other potential CollapsibleTables. I would add a new style property in the data and then switch the size based on the value of that property.

Copy link
Contributor

@rjohanek rjohanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dataset table on the SO console looks good and has wider name/id column!

@rushtong rushtong dismissed fboulnois’s stale review November 28, 2023 14:49

Feedback addressed

@hams7504 hams7504 merged commit 3d9fd5e into develop Nov 28, 2023
9 checks passed
@hams7504 hams7504 deleted the hm-duos-2757-increase-study-table-column-width branch November 28, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants