Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2805][risk=no] Add ts configurations #2413

Merged
merged 4 commits into from
Dec 13, 2023
Merged

[DUOS-2805][risk=no] Add ts configurations #2413

merged 4 commits into from
Dec 13, 2023

Conversation

rushtong
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2805

Summary

Adds a minimal set of configs for Typescript development in UI and test code

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner November 28, 2023 13:23
@rushtong rushtong mentioned this pull request Nov 28, 2023
Closed
hams7504
hams7504 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👍

fboulnois
fboulnois approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we had anyone from terra-ui review these configs?

@rushtong
Copy link
Contributor Author

rushtong commented Dec 5, 2023

Have we had anyone from terra-ui review these configs?

I did post this in the terra ui slack channel and Nick was kind enough to make a suggestion.

@rushtong rushtong merged commit 7962d92 into develop Dec 13, 2023
9 checks passed
@rushtong rushtong deleted the gr-tsx-configs-v2 branch December 13, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hams7504 hams7504 hams7504 approved these changes

@fboulnois fboulnois fboulnois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushtong @fboulnois @hams7504