Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2867] Address warning nits by eslint #2428

Merged
merged 2 commits into from
Jan 9, 2024
Merged

[DUOS-2867] Address warning nits by eslint #2428

merged 2 commits into from
Jan 9, 2024

Conversation

fboulnois
Copy link
Contributor

@fboulnois fboulnois commented Jan 5, 2024 •
edited
Loading

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2867

Summary

Address warning nits reported by eslint

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner January 5, 2024 16:32
@fboulnois fboulnois changed the title Address warning nits by eslint [DUOS-2867] Address warning nits by eslint Jan 5, 2024
rushtong
rushtong approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

rushtong
rushtong approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

rushtong
rushtong approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois merged commit 2de4d15 into develop Jan 9, 2024
9 checks passed
@fboulnois fboulnois deleted the fb-fix-minor-nits branch January 9, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snf2ye snf2ye snf2ye approved these changes

@rushtong rushtong rushtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fboulnois @rushtong @snf2ye