Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2853][risk=no] Cache doid responses in local storage #2432

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Jan 9, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2853

Summary

Cache DOID api calls so we don't make unnecessary API calls.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner January 9, 2024 21:09
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, how much does this improve performance in the typical case?

@rushtong
Copy link
Contributor Author

looks good, how much does this improve performance in the typical case?

The performance increase isn't that much, and depends greatly on the number of datasets you have access to. For someone like Jonathan, it will probably boost performance by 20% or so. For others, like me, very little.

@rushtong rushtong merged commit 57ddc0d into develop Jan 11, 2024
9 checks passed
@rushtong rushtong deleted the gr-DUOS-2853-cache-doids branch January 11, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants