Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2897] Remove more hyperscript helpers #2438

Merged
merged 38 commits into from
Jan 29, 2024

Conversation

fboulnois
Copy link
Contributor

@fboulnois fboulnois commented Jan 17, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2897

Summary

Follow-up to #2397. Switch pages and components to JSX.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner January 17, 2024 19:57
@fboulnois fboulnois marked this pull request as draft January 17, 2024 20:06
@fboulnois fboulnois force-pushed the fb-duos-2789-remove-more-hyperscript-helpers branch 6 times, most recently from 02267f9 to b8fb395 Compare January 19, 2024 20:26
@fboulnois fboulnois force-pushed the fb-duos-2789-remove-more-hyperscript-helpers branch from b8fb395 to d7aedc8 Compare January 19, 2024 20:32
@fboulnois fboulnois force-pushed the fb-duos-2789-remove-more-hyperscript-helpers branch from 4424335 to 4edb63c Compare January 22, 2024 21:33
@fboulnois fboulnois force-pushed the fb-duos-2789-remove-more-hyperscript-helpers branch from 3ad0c8a to 182c859 Compare January 22, 2024 22:59
@fboulnois fboulnois force-pushed the fb-duos-2789-remove-more-hyperscript-helpers branch from e7d254b to f4515b2 Compare January 23, 2024 15:19
@fboulnois fboulnois force-pushed the fb-duos-2789-remove-more-hyperscript-helpers branch from b102b39 to e06fa00 Compare January 23, 2024 16:21
@fboulnois fboulnois force-pushed the fb-duos-2789-remove-more-hyperscript-helpers branch from 2c9bb39 to 8e614f1 Compare January 26, 2024 16:41
@fboulnois fboulnois marked this pull request as ready for review January 26, 2024 16:47
@fboulnois fboulnois changed the title [DUOS-2789] Remove more hyperscript helpers [DUOS-2897] Remove more hyperscript helpers Jan 26, 2024
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fboulnois fboulnois merged commit 9f98d0e into develop Jan 29, 2024
9 checks passed
@fboulnois fboulnois deleted the fb-duos-2789-remove-more-hyperscript-helpers branch January 29, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants