Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2807] Add export to terra in DUOS libraries #2450

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

fboulnois
Copy link
Contributor

@fboulnois fboulnois commented Jan 29, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2807

Summary

See #2441 for the original PR. Add export to terra in DUOS libraries. This version is rebased on our latest develop. You will only see the button IF you have access to the dataset in TDR.

Testing this PR requires multiple steps:

  • You must use the same user for TDR and DUOS
  • You must have the terraUrl and tdrApiUrl variables defined in your configs, for example:
  "terraUrl": "https://bvdp-saturn-dev.appspot.com",
  "tdrApiUrl": "https://jade.datarepo-dev.broadinstitute.org",
  • You must create a snapshot and have action: share_policy::reader on it
  • You must assign the DUOS ID to the snapshot in the TDR UI

Once these steps are completed, you should be able to click the export to Terra button. After it is clicked, you will need to wait a few seconds until it is replaced with the export icon. Clicking that will start the import process.

If you get the error Invalid import request. Unable to load snapshot., then you need to clear your cookies for that specific Terra instance. There's a bug in Terra with storing a ton of OIDC stuff.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

- Optional expand and collapse subrow handlers
- Values can be a function now to enable dynamic rendering
@fboulnois fboulnois force-pushed the fb-duos-2807-export-to-terra-bis branch 2 times, most recently from a27365d to 4432052 Compare January 30, 2024 16:41
@fboulnois fboulnois force-pushed the fb-duos-2807-export-to-terra-bis branch from bd42b1f to 20e9a41 Compare January 30, 2024 17:35
@fboulnois fboulnois marked this pull request as ready for review January 30, 2024 17:44
@fboulnois fboulnois requested a review from a team as a code owner January 30, 2024 17:44
@rushtong rushtong self-requested a review February 5, 2024 19:21
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test this successfully 👍🏽 I can envision some additional enhancements like info panels describing which snapshot the export button points to, etc., but this is a great start.

Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I agree with Greg's comment above, but this seems to be an awesome start.

@fboulnois fboulnois merged commit 4b6afe7 into develop Feb 14, 2024
9 checks passed
@fboulnois fboulnois deleted the fb-duos-2807-export-to-terra-bis branch February 14, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants