Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2903][risk=no] Update dataset selection in DAR form #2451

Merged
merged 8 commits into from
Feb 13, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Feb 2, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2903

Summary

  • Convert from hyperscript to jsx
  • Use new dataset autocomplete API instead of slower search API
    • Note that the new API returns data in a slightly different form since it is not a full dataset object. For that reason, in several places in the code, we look for one of two property names like id and dataSetId or identifier and datasetIdentifier due to the different models.
  • Update the population and selection of dataset objects when populating the form
  • Ensure that we're not querying for invalid/null dataset ids

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

fix dataset selection and completion
first pass at hyperscript -> jsx
fix h4 titles
make object values consistent in form field props
bug fix: ensure duplicates are not visible in select
@rushtong rushtong marked this pull request as ready for review February 5, 2024 16:05
@rushtong rushtong requested a review from a team as a code owner February 5, 2024 16:05
Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below:

src/pages/dar_application/DataAccessRequest.js Outdated Show resolved Hide resolved
@rushtong rushtong requested a review from fboulnois February 12, 2024 18:51
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat idea, 👍

@rushtong rushtong merged commit 6c0cd4b into develop Feb 13, 2024
9 checks passed
@rushtong rushtong deleted the gr-DUOS-2903-fix-dataset-selections branch February 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants