-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUOS-2901] Add search bar to libraries #2456
[DUOS-2901] Add search bar to libraries #2456
Conversation
One detail I'm seeing is that the search bar and the access type filters are over-writing the results without changing the filter values. For example, enter a value in the search bar and it will filter records. Then check one of the access type checkboxes, and the search bar filter is no longer in effect, yet the value still shows in the search bar. A similar effect happens in reverse. I think we need to take into account BOTH the search bar value and the access type checkboxes in the search handler function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very impressed with this implementation, thank you! 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, a few minor suggestions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2901
Summary
Adds search bars to our two data libraries: Researcher Console, Data Library and SO Console, My Datasets.
Have you read Terra's Contributing Guide lately? If not, do that first.