Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2907, DUOS-2917][risk=no] Bug fix: Update use effect handler #2457

Merged
merged 3 commits into from
Feb 8, 2024
Merged

[DUOS-2907, DUOS-2917][risk=no] Bug fix: Update use effect handler #2457

merged 3 commits into from
Feb 8, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Feb 8, 2024 •
edited
Loading

Addresses

Summary

  • Credit to @fboulnois for the fix
  • Updates the use effect handler to eliminate an infinite reload problem

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner February 8, 2024 14:01
fboulnois
fboulnois requested changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change:

src/pages/DatasetSearch.js Outdated Show resolved Hide resolved
@rushtong rushtong requested a review from fboulnois February 8, 2024 14:13
aarohinadkarni
aarohinadkarni approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍

fboulnois
fboulnois reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below:

src/pages/DatasetSearch.js Outdated Show resolved Hide resolved
@rushtong rushtong requested a review from fboulnois February 8, 2024 15:18
@rushtong rushtong changed the title [DUOS-2917][risk=no] Bug fix: Update use effect handler [DUOS-2907, DUOS-2917][risk=no] Bug fix: Update use effect handler Feb 8, 2024
fboulnois
fboulnois approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rushtong rushtong merged commit a932086 into develop Feb 8, 2024
9 checks passed
@rushtong rushtong deleted the gr-data-library-use-effect-fix branch February 8, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarohinadkarni aarohinadkarni aarohinadkarni approved these changes

@fboulnois fboulnois fboulnois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushtong @fboulnois @aarohinadkarni