Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCJ-89][risk=no] Import libraries necessary for B2C auth #2575

Merged
merged 2 commits into from
May 9, 2024
Merged

[DCJ-89][risk=no] Import libraries necessary for B2C auth #2575

merged 2 commits into from
May 9, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented May 8, 2024

Addresses

Addresses, but does not complete, work done for https://broadworkbench.atlassian.net/browse/DCJ-89

Summary

This PR just introduces the libraries necessary to support #2512

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner May 8, 2024 20:09
@rushtong rushtong requested review from fboulnois and okotsopoulos and removed request for a team May 8, 2024 20:09
fboulnois
fboulnois reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts need to be resolved.

@rushtong
Merge branch 'refs/heads/develop' into gr-DCJ-89-libraries
dd1f247 
# Conflicts:
#	package-lock.json
#	package.json
@rushtong rushtong requested a review from aarohinadkarni May 9, 2024 14:39
fboulnois
fboulnois approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

aarohinadkarni
aarohinadkarni approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rushtong rushtong merged commit f195e54 into develop May 9, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-89-libraries branch May 9, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarohinadkarni aarohinadkarni aarohinadkarni approved these changes

@fboulnois fboulnois fboulnois approved these changes

@okotsopoulos okotsopoulos Awaiting requested review from okotsopoulos okotsopoulos was automatically assigned from DataBiosphere/data-custodian-journeys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushtong @fboulnois @aarohinadkarni