DCJ-649: Use OidcBroker for sign-out functionality #2657
Conversation
rushtong
requested review from
fboulnois and
okotsopoulos
and removed request for
a team
rushtong
changed the title
rushtong
changed the title
# Conflicts: # src/App.jsx # src/components/DuosHeader.jsx
| path: cypress/screenshots | ||
| if-no-files-found: ignore # 'warn' or 'error' are also available, defaults to `warn` | ||
| - uses: actions/upload-artifact@v4 | ||
| with: |
There was a problem hiding this comment.
Should this also have if: failure()?
| }); | ||
| await Auth.initialize(); | ||
| }); | ||
| it('Sign Out Clears the session when called', async function () { |
There was a problem hiding this comment.
Do you store anything in localStorage on DUOS? That might also be good to check if so.
There was a problem hiding this comment.
We do - I'll boost the uses of Storage.setXYZ() and check those too, thank you!
|
|
||
| const text = 'TOS Text'; | ||
| const mocks = { | ||
| history: { push() {} } | ||
| history: { |
There was a problem hiding this comment.
Nit: Is this a lint change? I personally find it more readable the other way.
There was a problem hiding this comment.
Yes, that's it exactly - I manually unformatted it, then ran our eslint checks and it made the same change.
| await Storage.clearStorage(); | ||
| await setIsLoggedIn(false); | ||
| }; | ||
|
|
||
| const signIn = async () => { |
There was a problem hiding this comment.
This will move to OIDC with https://broadworkbench.atlassian.net/browse/DCJ-654, correct?
There was a problem hiding this comment.
Correct. I'm trying to de-tangle the sign-in code here so it's less of a boil-the-ocean change.
Both sign-in and sign-out are fully functional. Sign-in is the bigger lift so I'm working on that now, but separately. The sign-out exercises both the old way of clearing local storage as well as triggering the OIDC library sign-out functionality. |
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-649
auth.ts: https://broadworkbench.atlassian.net/browse/DCJ-328oidcBroker.ts: https://broadworkbench.atlassian.net/browse/DCJ-330Summary
auth.tsis a minimized version ofauth.tsin the above PRoidcBroker.tsis a minimized version ofoidcBroker.tsin the above PRFollow-on work is defined in a variety of tickets under the DUOS-2534 epic.
Testing Notes
Testing should include reviewing the developer panel in a browser when logging into a local instance.
Have you read Terra's Contributing Guide lately? If not, do that first.