Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-903: Change export button to link directly to terra-ui import page #2711

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

pshapiro4broad
Copy link
Member

@pshapiro4broad pshapiro4broad commented Nov 5, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DT-903

Instead of performing a two-step operation in the duos UI, use the new TDR import link to have terra-ui perform the TDR export step. The same APIs are called in both cases, so other than the UX differences there is no difference in behavior.

Summary

Video clip showing behavior, note that this is trying to export an azure dataset so the final step is blocked, but everything else is working correctly.

export.mov

@pshapiro4broad pshapiro4broad requested a review from a team as a code owner November 5, 2024 17:07
@pshapiro4broad pshapiro4broad requested review from rjohanek and cinyecai and removed request for a team November 5, 2024 17:07
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the simplification 👍

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this works for the known positive case and fails in the known auth-domain case.

Working example:

Screenshot 2024-11-05 at 12 55 41 PM

Failing example:
Screenshot 2024-11-05 at 12 55 50 PM

I am seeing the export link twice when there are multiple snapshots, so we still need to address that at some point:
Screenshot 2024-11-05 at 12 57 58 PM

@fboulnois
Copy link
Contributor

I am seeing the export link twice when there are multiple snapshots, so we still need to address that at some point:

At a minimum we probably want a bit of spacing between the links.

}

return null;
const link = `${terraUrl}/#import-data?snapshotId=${snapshot.id}&format=tdrexport&tdrSyncPermissions=false`;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pshapiro4broad pshapiro4broad changed the title Change export button to link directly to terra-ui import page DT-903: Change export button to link directly to terra-ui import page Nov 5, 2024
@pshapiro4broad
Copy link
Member Author

pshapiro4broad commented Nov 5, 2024

I've added spacing between the links. There's not much room for multiple Exports, but we have other tickets for that issue, so I'm not going to address that now.

image

@pshapiro4broad pshapiro4broad merged commit 2bada7b into develop Nov 5, 2024
9 checks passed
@pshapiro4broad pshapiro4broad deleted the ps/dt-903-export-workspace-button branch November 5, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants