Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-980] Fix the enumerate snapshots to get more snapshots than the first 10 #2719

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

s-rubenstein
Copy link
Contributor

Addresses

This makes it so we load snapshots only once to avoid debounce issues and ensure that we have a comprehensive list of what can export always.

It also bumps up the limits on snapshots from 10 (the default) to 1000 - this should be a safe number given that we partition DUOS IDs into 70 at a time.

Summary


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@s-rubenstein s-rubenstein requested a review from a team as a code owner November 7, 2024 18:27
@s-rubenstein s-rubenstein requested review from snf2ye and cinyecai and removed request for a team November 7, 2024 18:27
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the limit parameter 👍🏽

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@s-rubenstein s-rubenstein merged commit 8e42af6 into develop Nov 7, 2024
9 checks passed
@s-rubenstein s-rubenstein deleted the sr/dt-980-make-snapshots-only-load-once branch November 7, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants