Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-1056] Replace local config interception with initApplicationConfig #2736

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-1056

Summary

@rushtong created this method to avoid code duplication in our Cypress tests


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner November 21, 2024 16:07
@fboulnois fboulnois requested review from pshapiro4broad and rjohanek and removed request for a team November 21, 2024 16:07
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see that this works in both js and ts tests! I had tried this myself and was running into errors that seem to have been only on my end. 👍🏽

Copy link
Member

@pshapiro4broad pshapiro4broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me but I don't understand how the typescript typing of a custom cypress command works.

@fboulnois fboulnois merged commit 4ed3774 into develop Nov 22, 2024
9 checks passed
@fboulnois fboulnois deleted the fb-dt-1056-init-application-config branch November 22, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants