-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DT-1072] Add Getz Lab data library #2739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, is there any testing we want to do for this?
Yes, do you have any thoughts on how I might write a test like "if it's this particular Data Library, then expect to see this title"? |
Maybe you could use cypress.visit(url) to access the specific data library instead of using mountComponent like we usually do? If the specific library page info is stored via props to component, you could still use mountComponent, but I don't think it is right? so you might have to use visit to access the url directly. And then check for the title ? and maybe the filtered datasets too. I haven't done this before but I'd be happy to talk about it if you'd like! https://docs.cypress.io/api/commands/visit |
Using |
That makes sense, if we aren't looking to add integration tests then maybe you could mount the DatasetSearch component with the query (as a prop) that would be specified by this route and then check for the filtered datasets |
I'm going to create a separate ticket for unit tests of the data libraries to unblock this ticket. |
Addresses
https://broadworkbench.atlassian.net/browse/DT-1072
Summary
Adds a Getz Lab data library that lives at
/datalibrary/getzlab
.Have you read Terra's Contributing Guide lately? If not, do that first.