[DT-1079] Switch from MomentJS to DayJS #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboulnois
requested review from
rushtong and
pshapiro4broad
and removed request for
a team
fboulnois
force-pushed
the
fb-dt-1079-switch-to-dayjs
branch
from
5a5c24d to
147b73b
Compare
fboulnois
commented
Dec 3, 2024
| @@ -14,11 +14,11 @@ | |||
| "ajv": "8.17.1", | |||
| "ajv-formats": "3.0.1", | |||
| "axios": "1.7.8", | |||
| "dayjs": "1.11.3", | |||
There was a problem hiding this comment.
I didn't switch to the latest version of dayjs to minimize the diffs in the package-lock.json.
There was a problem hiding this comment.
I'm sure we'll get a dependabot PR for that, which will be nice to keep it isolated.
s-rubenstein
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-1079
Summary
Elliot is working on a date picker component that relies on DayJS, which is similar to MomentJS. We only rely on MomentJS for a single page, and the functionality we rely on is very minimal. Also, we already transitively depend on DayJS due to Cypress. Finally, MomentJS is substantially smaller, faster and less outdated.
This PR switches from MomentJS to DayJS.
Have you read Terra's Contributing Guide lately? If not, do that first.