Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1083: Use global DAA config instead of environment #2743

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Dec 4, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DT-1083

Summary

This is another case of a DAA feature that should be using the global config, but is instead using an environment config. See also #2742 for a similar case.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner December 4, 2024 19:02
@rushtong rushtong requested review from snf2ye and fboulnois and removed request for a team December 4, 2024 19:02
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rushtong rushtong merged commit 7776af9 into develop Dec 10, 2024
9 checks passed
@rushtong rushtong deleted the gr-DT-1083-fix-researcher-status-daas branch December 10, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants