[DT-1072] Make minor updates to DEVNOTES.md #2744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboulnois
requested review from
rushtong and
rjohanek
and removed request for
a team
fboulnois
commented
Dec 4, 2024
| @@ -18,18 +18,21 @@ environment by looking at the deployed configs in https://duos-k8s.dsde-{%ENV%}. | |||
| `dev`. Certain features are available only in specific environments. Setting the `env` value to the desired environment | |||
| will simulate it for local development. The installation steps outlined in this step can also be completed using the | |||
| [render-configs.sh](scripts/render-configs.sh) script which can generate all required files for local development. | |||
|
|
|||
There was a problem hiding this comment.
These additional spaces are added because not all markdown parsers recognize the triple backticks directly after a string.
fboulnois
commented
Dec 4, 2024
| ```shell | ||
| gcloud container clusters get-credentials --zone us-central1-a --project <project> terra-dev | ||
| gcloud container clusters get-credentials --zone us-central1-a --project broad-dsde-dev terra-dev |
There was a problem hiding this comment.
This is the main change, we mention downloading the cert files from the dev project, so this is specified.
There was a problem hiding this comment.
I believe that you can run render-configs and it will pick up on that project by default - I happened to also make a round of changes to the devnotes in this PR, what do you think?
There was a problem hiding this comment.
I'll close this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-1072
Summary
Fallout from DT-1072 when I was trying to update my local certificates. Updates the documentation to be more specific.
Have you read Terra's Contributing Guide lately? If not, do that first.