[DT-1081] Typescriptify the filters file #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-rubenstein
requested review from
fboulnois and
cinyecai
and removed request for
a team
s-rubenstein
requested review from
pshapiro4broad
and removed request for
cinyecai
pshapiro4broad
approved these changes
Dec 9, 2024
| export const FilterItemList = (props) => { | ||
| interface FilterItemListProps { | ||
| category: string; | ||
| datasets: DatasetTerm[] |
There was a problem hiding this comment.
This declares datasets but this prop is not extracted below. Is the idea that it will be needed in the future?
| max: number; | ||
| minCategory: string; | ||
| maxCategory: string; | ||
| datasets: DatasetTerm[]; |
There was a problem hiding this comment.
This also appears to be unused
Comment on lines
9
to
10
| import { Button, TextField, Typography } from '@mui/material'; | ||
| import { Checkbox } from '@mui/material'; |
There was a problem hiding this comment.
Not related to this PR, but I think these two imports can be merged into one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
I wanted to make this typescript before I went chasing bugs down.
Summary
Have you read Terra's Contributing Guide lately? If not, do that first.