Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-1077] typescriptify datasetstatistics and fix #2757

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

s-rubenstein
Copy link
Contributor

Addresses

I noticed the issue appeared to be based on properties missing, so I added a test with no additional properties that still renders.

I opted not to put in the additional effort to typescriptify the test, because test files are much less impact as js vs ts, and if we decide to move unit tests to jest eventually, I wanted to prioritize effort.

Summary


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@s-rubenstein s-rubenstein requested a review from a team as a code owner December 18, 2024 20:44
@s-rubenstein s-rubenstein requested review from pshapiro4broad and snf2ye and removed request for a team December 18, 2024 20:44
@@ -1,6 +0,0 @@

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is side by side with a models.js file, and the capitalization being the only difference was causing issues. Given this was only used in one place I just moved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant