[DT-1074] Move to request scoped metrics #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-rubenstein
requested review from
pshapiro4broad and
rjohanek
and removed request for
a team
pshapiro4broad
approved these changes
Jan 16, 2025
src/main/java/bio/terra/app/usermetrics/UserLoggingMetrics.java
Outdated
Show resolved
Hide resolved
src/main/java/bio/terra/app/usermetrics/UserLoggingMetrics.java
Outdated
Show resolved
Hide resolved
src/main/java/bio/terra/app/usermetrics/UserMetricsInterceptor.java
Outdated
Show resolved
Hide resolved
|
rjohanek
reviewed
Jan 17, 2025
| @@ -11,38 +13,36 @@ | |||
| * API request will get grouped together even if they are set in different methods. | |||
| */ | |||
| @Component | |||
| @RequestScope | |||
There was a problem hiding this comment.
🤔 I think request scope is the right approach for this component. However, this change means that this class can now only be used in a request context. Before, if it was referenced outside of a request context (such as in a flight), the data would be stored in a map but never used. Now it will generate a runtime exception.
There are only three uses of this currently and all are with a request scope, but it's something to keep in mind.
|
@rjohanek done |
rjohanek
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/dt-1074
Addresses
This adds request scoping to replace threads managing the cache. The advantage of this is the request scoping cleans things up for us, whereas if the thread is directly in control the cache may not be cleared. Making this change helps to ensure that data doesn't bleed from one request to another.
Summary of changes
Testing Strategy