Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA-4840] [DO NOT MERGE] Testing running jupyter server from docker container for ToA #4465

Open
wants to merge 60 commits into
base: develop
Choose a base branch
from

Conversation

LizBaldo
Copy link
Collaborator

@LizBaldo LizBaldo commented Apr 22, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/IA-4840

Summary of changes

What

  • Replaces the jupyter server native to the DSVM, with the one from our ToA jupyter base image
  • This required a bunch of clean up and fixes along the way, such as making sure that user ids are the same between the VM and the containers

Why

Testing these changes

I deployed this branch on my BEE (ebaldo) and can successfully create a running Jupyter Runtime on Azure 🎉 and verified that Welder is working, and I can successfully pause and resume the runtime.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.99%. Comparing base (2d4dcfd) to head (f868925).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4465   +/-   ##
========================================
  Coverage    73.99%   73.99%           
========================================
  Files          159      159           
  Lines        14784    14784           
  Branches      1231     1231           
========================================
  Hits         10939    10939           
  Misses        3845     3845           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d4dcfd...f868925. Read the comment docs.

@LizBaldo LizBaldo marked this pull request as ready for review April 25, 2024 17:49
@LizBaldo LizBaldo requested review from lucymcnatt and cpate4 April 25, 2024 17:50
Copy link
Collaborator

@lucymcnatt lucymcnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small questions, otherwise lgtm

@LizBaldo
Copy link
Collaborator Author

LizBaldo commented May 3, 2024

@lucymcnatt and @cpate4 everything is working now and ready for a final review, albeit with a need for a lot of bash gymnastic 😭 LMK what you think!

@LizBaldo LizBaldo changed the title [IA-4840] Testing running jupyter server from docker container for ToA [IA-4840] [DO NOT MERGE] Testing running jupyter server from docker container for ToA May 3, 2024
@cpate4 cpate4 removed their request for review September 6, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants