-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IA-4840] [DO NOT MERGE] Testing running jupyter server from docker container for ToA #4465
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4465 +/- ##
========================================
Coverage 73.99% 73.99%
========================================
Files 159 159
Lines 14784 14784
Branches 1231 1231
========================================
Hits 10939 10939
Misses 3845 3845 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small questions, otherwise lgtm
@lucymcnatt and @cpate4 everything is working now and ready for a final review, albeit with a need for a lot of bash gymnastic 😭 LMK what you think! |
Jira ticket: https://broadworkbench.atlassian.net/browse/IA-4840
Summary of changes
What
Why
Testing these changes
I deployed this branch on my BEE (
ebaldo
) and can successfully create a running Jupyter Runtime on Azure 🎉 and verified that Welder is working, and I can successfully pause and resume the runtime.