Simplify merge translator + add test #1151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexamundsen
commented
Jan 30, 2025
| @@ -74,15 +75,14 @@ public static SequencedJobSet getJobSetForEntity( | |||
| jobSet.startNewStage(); | |||
|
|
|||
| entity | |||
| .getOptimizeSearchByAttributes() | |||
| .getOptimizeSearchByAttributeNames() | |||
There was a problem hiding this comment.
rename and change to set since it is better for perf (contains all function)
dexamundsen
commented
Jan 30, 2025
| String filterType = filters.get(0).getClass().getName(); | ||
| return filters.stream().allMatch(filter -> filter.getClass().getName().equals(filterType)); | ||
| Class<?> firstClazz = filters.get(0).getClass(); | ||
| return filters.stream().skip(1).allMatch(filter -> filter.getClass().equals(firstClazz)); |
There was a problem hiding this comment.
skip 1 to avoid comparing first element to itself
tjennison-work
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify merge translator (will be used in next pr to merge other filters)
add test