Add Toil appliance (resolves #1142) #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannes-ucsc
changed the title
|
Jenkins, test this please. |
1 similar comment
|
Jenkins, test this please. |
| --self=$(docker_registry)/$(docker_base_name)-$*:$(docker_tag) > $@ | ||
|
|
||
| clean_docker: | ||
| -rm docker/Dockerfile.{leader,worker} docker/$(sdist_name) |
There was a problem hiding this comment.
Perhaps docker rmi on the built images as well?
|
LGTM overall, dropped a few comments inline. |
hannes-ucsc
force-pushed
the
issues/1142-toil-appliance
branch
from
ff84bde
to
8ad1033
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes some Makefile mechanics (printf instead of echo, switch to bash as subshell). Thanks to @cket and @fnothaft for writing the initial version of the Dockerfile.
Connected to #1088.
Also sneaks in a change that moves the
retrycontext manager to bd2k-python-lib.