Use pre-3.10 union syntax in WDL runner #5060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5041 by using syntax that older Pythons can actually understand when talking about union types in executable code. It turns out there wasn't a race; the #5030 PR that introduced the problem changed more than just the dependency version, and we didn't test it on older Python versions as part of the PR CI pipeline.
Changelog Entry
To be copied to the draft changelog by merger:
toil-wdl-runner
works again on Python 3.8 and 3.9 after MiniWDL version upgradeReviewer Checklist
issues/XXXX-fix-the-thing
in the Toil repo, or from an external repo.camelCase
that want to be insnake_case
.docs/running/{cliOptions,cwl,wdl}.rst
Merger Checklist