Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill all grid engine jobs on shutdown #5083

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

adamnovak
Copy link
Member

I think all batch systems are meant to kill outstanding jobs at shutdown() like the Kuberentes one does, but the Grid Engine batch systems didn't seem to implement it.

This should fix that.

It would be nice to test this requirement across all batch systems somehow, but that's not in this.

This should fix #5082 but I think still needs some manual testing.

Changelog Entry

To be copied to the draft changelog by merger:

  • Grid Engine batch systems now send the required job kills when shut down

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passes tests.
  • Make sure the PR has been reviewed since its last modification. If not, review it.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@adamnovak
Copy link
Member Author

OK, I tested this manually, and toil kill on the job store now properly ends up with the running jobs going to the CANCELLED state in Slurm.

@adamnovak adamnovak marked this pull request as ready for review September 16, 2024 15:44
@DailyDreaming DailyDreaming merged commit 3c4b121 into master Sep 16, 2024
3 checks passed
@DailyDreaming DailyDreaming deleted the issues/5082-kill-jobs-at-shutdown branch September 16, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slurm jobs can stay running after toil kill
2 participants