feat(profiling): add threading.RLock support to the Lock profiler (re-entrant lock) #14823

vlad-scherbich · 2025-10-09T02:43:28Z

Description

This PR adds profiling support for a new kind of synchronization mechanism: Reentrant Lock. A RLock is a lock that can be acquired by the same thread multiple times without blocking on itself. From the documentation:

Once a thread has acquired a reentrant lock, the same thread may acquire it again without blocking; the thread must release it once for each time it has acquired it.

This feature was identified as one of the most - low-hanging-fruits, since RLocks are being used extensively in Python world.

Changes

added new ThreadingRLockCollector class in threading.py
register the new collector in Profiler in profiler.py
current test_threading.py module has been updated to reuse existing tests for both Lock and RLock primitives (via new inheritance)
test_global_locks test rewritten extensively to support the unit test code reuse between Lock and RLock (effectively duplicating the existing extensive Lock unit tests for RLock ... without the code duplication)

Testing

added new unit tests
added new e2e test:

Reentrant behavior works for multi-level acquisition
Thread contention handling validated

Risks

none

Additional Notes

RLock docs

github-actions · 2025-10-09T02:44:36Z

CODEOWNERS have been resolved as:

releasenotes/notes/feat-profiling-rlock-support-e8607e68252647.yaml     @DataDog/apm-python
ddtrace/profiling/collector/threading.py                                @DataDog/profiling-python
ddtrace/profiling/profiler.py                                           @DataDog/profiling-python
tests/profiling_v2/collector/test_threading.py                          @DataDog/profiling-python
tests/profiling_v2/test_profiler.py                                     @DataDog/profiling-python
tests/profiling/collector/global_locks.py                               @DataDog/profiling-python

github-actions · 2025-10-09T03:09:07Z

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 238 ± 2 ms.

The average import time from base is: 240 ± 2 ms.

The import time difference between this PR and base is: -2.5 ± 0.09 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.052 ms (0.86%)

ddtrace.bootstrap.sitecustomize 1.378 ms (0.58%)

ddtrace.bootstrap.preload 1.378 ms (0.58%)

ddtrace.internal.remoteconfig.client 0.672 ms (0.28%)

ddtrace 0.674 ms (0.28%)

ddtrace.internal._unpatched 0.029 ms (0.01%)

json 0.029 ms (0.01%)

json.decoder 0.029 ms (0.01%)

re 0.029 ms (0.01%)

enum 0.029 ms (0.01%)

types 0.029 ms (0.01%)

pr-commenter · 2025-10-09T03:58:02Z

Performance SLOs

Comparing candidate vlad/lock-profiler-add-rlock (45abc7f) with baseline main (b766bf5)

🟡 Near SLO Breach (5 suites)

🟡 djangosimple - 30/30

✅ appsec

Time: ✅ 20.473ms (SLO: <22.300ms -8.2%) vs baseline: +0.2%

Memory: ✅ 65.477MB (SLO: <67.000MB -2.3%) vs baseline: +5.0%

✅ exception-replay-enabled

Time: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: +0.3%

Memory: ✅ 64.643MB (SLO: <67.000MB -3.5%) vs baseline: +5.1%

✅ iast

Time: ✅ 20.421ms (SLO: <22.250ms -8.2%) vs baseline: -0.3%

Memory: ✅ 65.495MB (SLO: <67.000MB -2.2%) vs baseline: +5.0%

✅ profiler

Time: ✅ 15.543ms (SLO: <16.550ms -6.1%) vs baseline: +1.9%

Memory: ✅ 53.949MB (SLO: <54.500MB 🟡 -1.0%) vs baseline: +5.2%

✅ resource-renaming

Time: ✅ 20.528ms (SLO: <21.750ms -5.6%) vs baseline: ~same

Memory: ✅ 65.464MB (SLO: <67.000MB -2.3%) vs baseline: +4.9%

✅ span-code-origin

Time: ✅ 26.146ms (SLO: <28.200ms -7.3%) vs baseline: ~same

Memory: ✅ 67.472MB (SLO: <69.500MB -2.9%) vs baseline: +4.6%

✅ tracer

Time: ✅ 20.433ms (SLO: <21.750ms -6.1%) vs baseline: -0.2%

Memory: ✅ 65.434MB (SLO: <67.000MB -2.3%) vs baseline: +4.8%

✅ tracer-and-profiler

Time: ✅ 22.552ms (SLO: <23.500ms -4.0%) vs baseline: +2.3%

Memory: ✅ 66.917MB (SLO: <67.500MB 🟡 -0.9%) vs baseline: +5.3%

✅ tracer-dont-create-db-spans

Time: ✅ 19.332ms (SLO: <21.500ms 📉 -10.1%) vs baseline: ~same

Memory: ✅ 65.514MB (SLO: <66.000MB 🟡 -0.7%) vs baseline: +4.8%

✅ tracer-minimal

Time: ✅ 16.590ms (SLO: <17.500ms -5.2%) vs baseline: -0.3%

Memory: ✅ 65.391MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.8%

✅ tracer-native

Time: ✅ 20.486ms (SLO: <21.750ms -5.8%) vs baseline: +0.2%

Memory: ✅ 71.376MB (SLO: <72.500MB 🟡 -1.6%) vs baseline: +4.9%

✅ tracer-no-caches

Time: ✅ 18.412ms (SLO: <19.650ms -6.3%) vs baseline: -0.2%

Memory: ✅ 65.432MB (SLO: <67.000MB -2.3%) vs baseline: +4.8%

✅ tracer-no-databases

Time: ✅ 18.742ms (SLO: <20.100ms -6.8%) vs baseline: ~same

Memory: ✅ 65.403MB (SLO: <67.000MB -2.4%) vs baseline: +4.8%

✅ tracer-no-middleware

Time: ✅ 20.134ms (SLO: <21.500ms -6.4%) vs baseline: -0.2%

Memory: ✅ 65.382MB (SLO: <67.000MB -2.4%) vs baseline: +4.8%

✅ tracer-no-templates

Time: ✅ 20.239ms (SLO: <22.000ms -8.0%) vs baseline: -0.1%

Memory: ✅ 65.450MB (SLO: <67.000MB -2.3%) vs baseline: +4.8%

🟡 errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 17.998ms (SLO: <19.850ms -9.3%) vs baseline: -0.5%

Memory: ✅ 65.215MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8%

✅ errortracking-enabled-user

Time: ✅ 18.048ms (SLO: <19.400ms -7.0%) vs baseline: ~same

Memory: ✅ 65.156MB (SLO: <66.500MB -2.0%) vs baseline: +4.7%

✅ tracer-enabled

Time: ✅ 18.085ms (SLO: <19.450ms -7.0%) vs baseline: +0.3%

Memory: ✅ 65.215MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9%

🟡 flasksimple - 18/18

✅ appsec-get

Time: ✅ 4.580ms (SLO: <4.750ms -3.6%) vs baseline: ~same

Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +4.8%

✅ appsec-post

Time: ✅ 6.571ms (SLO: <6.750ms -2.7%) vs baseline: -0.2%

Memory: ✅ 61.912MB (SLO: <65.000MB -4.8%) vs baseline: +4.7%

✅ appsec-telemetry

Time: ✅ 4.573ms (SLO: <4.750ms -3.7%) vs baseline: -0.1%

Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +4.8%

✅ debugger

Time: ✅ 1.866ms (SLO: <2.000ms -6.7%) vs baseline: +0.7%

Memory: ✅ 45.456MB (SLO: <47.000MB -3.3%) vs baseline: +4.9%

✅ iast-get

Time: ✅ 1.881ms (SLO: <2.000ms -6.0%) vs baseline: +0.7%

Memory: ✅ 42.369MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.8%

✅ profiler

Time: ✅ 1.914ms (SLO: <2.100ms -8.8%) vs baseline: ~same

Memory: ✅ 46.498MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +4.8%

✅ resource-renaming

Time: ✅ 3.381ms (SLO: <3.650ms -7.4%) vs baseline: -0.2%

Memory: ✅ 52.239MB (SLO: <53.500MB -2.4%) vs baseline: +4.9%

✅ tracer

Time: ✅ 3.378ms (SLO: <3.650ms -7.4%) vs baseline: +0.4%

Memory: ✅ 52.219MB (SLO: <53.500MB -2.4%) vs baseline: +4.7%

✅ tracer-native

Time: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: -0.3%

Memory: ✅ 58.283MB (SLO: <60.000MB -2.9%) vs baseline: +4.9%

🟡 otelspan - 22/22

✅ add-event

Time: ✅ 42.641ms (SLO: <47.150ms -9.6%) vs baseline: +1.1%

Memory: ✅ 44.425MB (SLO: <47.000MB -5.5%) vs baseline: +4.7%

✅ add-metrics

Time: ✅ 317.350ms (SLO: <344.800ms -8.0%) vs baseline: +0.4%

Memory: ✅ 594.649MB (SLO: <600.000MB 🟡 -0.9%) vs baseline: +4.8%

✅ add-tags

Time: ✅ 288.177ms (SLO: <314.000ms -8.2%) vs baseline: +0.3%

Memory: ✅ 596.701MB (SLO: <600.000MB 🟡 -0.5%) vs baseline: +4.9%

✅ get-context

Time: ✅ 80.844ms (SLO: <92.350ms 📉 -12.5%) vs baseline: +0.4%

Memory: ✅ 39.946MB (SLO: <46.500MB 📉 -14.1%) vs baseline: +4.9%

✅ is-recording

Time: ✅ 38.855ms (SLO: <44.500ms 📉 -12.7%) vs baseline: -0.1%

Memory: ✅ 43.911MB (SLO: <47.500MB -7.6%) vs baseline: +4.7%

✅ record-exception

Time: ✅ 58.560ms (SLO: <67.650ms 📉 -13.4%) vs baseline: -0.5%

Memory: ✅ 40.253MB (SLO: <47.000MB 📉 -14.4%) vs baseline: +4.7%

✅ set-status

Time: ✅ 44.711ms (SLO: <50.400ms 📉 -11.3%) vs baseline: -0.7%

Memory: ✅ 43.944MB (SLO: <47.000MB -6.5%) vs baseline: +4.8%

✅ start

Time: ✅ 38.268ms (SLO: <43.450ms 📉 -11.9%) vs baseline: +0.3%

Memory: ✅ 43.909MB (SLO: <47.000MB -6.6%) vs baseline: +4.7%

✅ start-finish

Time: ✅ 82.834ms (SLO: <88.000ms -5.9%) vs baseline: ~same

Memory: ✅ 34.524MB (SLO: <46.500MB 📉 -25.8%) vs baseline: +4.7%

✅ start-finish-telemetry

Time: ✅ 85.674ms (SLO: <89.000ms -3.7%) vs baseline: +1.2%

Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.9%

✅ update-name

Time: ✅ 40.237ms (SLO: <45.150ms 📉 -10.9%) vs baseline: +0.3%

Memory: ✅ 44.152MB (SLO: <47.000MB -6.1%) vs baseline: +4.7%

🟡 span - 26/26

✅ add-event

Time: ✅ 20.659ms (SLO: <22.500ms -8.2%) vs baseline: -0.2%

Memory: ✅ 50.348MB (SLO: <53.000MB -5.0%) vs baseline: +4.8%

✅ add-metrics

Time: ✅ 90.265ms (SLO: <93.500ms -3.5%) vs baseline: -1.3%

Memory: ✅ 660.931MB (SLO: <961.000MB 📉 -31.2%) vs baseline: +4.8%

✅ add-tags

Time: ✅ 148.722ms (SLO: <155.000ms -4.1%) vs baseline: +0.6%

Memory: ✅ 661.417MB (SLO: <962.500MB 📉 -31.3%) vs baseline: +4.8%

✅ get-context

Time: ✅ 19.339ms (SLO: <20.500ms -5.7%) vs baseline: +0.1%

Memory: ✅ 49.137MB (SLO: <53.000MB -7.3%) vs baseline: +4.8%

✅ is-recording

Time: ✅ 19.633ms (SLO: <20.500ms -4.2%) vs baseline: -0.3%

Memory: ✅ 49.229MB (SLO: <53.000MB -7.1%) vs baseline: +5.0%

✅ record-exception

Time: ✅ 38.546ms (SLO: <40.000ms -3.6%) vs baseline: +0.2%

Memory: ✅ 42.755MB (SLO: <53.000MB 📉 -19.3%) vs baseline: +4.7%

✅ set-status

Time: ✅ 21.298ms (SLO: <22.000ms -3.2%) vs baseline: +0.1%

Memory: ✅ 49.182MB (SLO: <53.000MB -7.2%) vs baseline: +5.0%

✅ start

Time: ✅ 19.238ms (SLO: <20.500ms -6.2%) vs baseline: +0.6%

Memory: ✅ 49.256MB (SLO: <53.000MB -7.1%) vs baseline: +5.1%

✅ start-finish

Time: ✅ 51.484ms (SLO: <52.500ms 🟡 -1.9%) vs baseline: -0.2%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7%

✅ start-finish-telemetry

Time: ✅ 53.039ms (SLO: <54.500ms -2.7%) vs baseline: +0.6%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ start-finish-traceid128

Time: ✅ 55.812ms (SLO: <56.000ms 🟡 -0.3%) vs baseline: +1.8%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ start-traceid128

Time: ✅ 19.974ms (SLO: <22.500ms 📉 -11.2%) vs baseline: +2.7%

Memory: ✅ 49.105MB (SLO: <53.000MB -7.3%) vs baseline: +4.9%

✅ update-name

Time: ✅ 20.493ms (SLO: <22.000ms -6.8%) vs baseline: +2.0%

Memory: ✅ 49.787MB (SLO: <53.000MB -6.1%) vs baseline: +5.0%

⚠️ Unstable Tests (1 suite)

⚠️

coreapiscenario - 10/10 (1 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.271µs (SLO: <20.000µs 📉 -33.6%) vs baseline: ~same

Memory: ✅ 32.106MB (SLO: <33.500MB -4.2%) vs baseline: +5.0%

✅ context_with_data_no_listeners

Time: ✅ 3.312µs (SLO: <10.000µs 📉 -66.9%) vs baseline: +0.5%

Memory: ✅ 32.106MB (SLO: <33.500MB -4.2%) vs baseline: +4.7%

✅ get_item_exists

Time: ✅ 0.580µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.9%

Memory: ✅ 32.126MB (SLO: <33.500MB -4.1%) vs baseline: +4.9%

✅ get_item_missing

Time: ✅ 0.636µs (SLO: <10.000µs 📉 -93.6%) vs baseline: +0.7%

Memory: ✅ 32.047MB (SLO: <33.500MB -4.3%) vs baseline: +4.5%

✅ set_item

Time: ✅ 24.327µs (SLO: <30.000µs 📉 -18.9%) vs baseline: -1.0%

Memory: ✅ 32.126MB (SLO: <33.500MB -4.1%) vs baseline: +4.9%

✅ All Tests Passing (18 suites)

✅ errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.084ms (SLO: <2.300ms -9.4%) vs baseline: -0.1%

Memory: ✅ 51.983MB (SLO: <53.500MB -2.8%) vs baseline: +4.5%

✅ errortracking-enabled-user

Time: ✅ 2.094ms (SLO: <2.250ms -6.9%) vs baseline: +0.9%

Memory: ✅ 52.101MB (SLO: <53.500MB -2.6%) vs baseline: +4.9%

✅ tracer-enabled

Time: ✅ 2.094ms (SLO: <2.300ms -8.9%) vs baseline: +1.0%

Memory: ✅ 52.081MB (SLO: <53.500MB -2.7%) vs baseline: +4.7%

✅ flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 3.930ms (SLO: <4.200ms -6.4%) vs baseline: ~same

Memory: ✅ 62.148MB (SLO: <66.000MB -5.8%) vs baseline: +4.7%

✅ iast-enabled

Time: ✅ 2.464ms (SLO: <2.800ms 📉 -12.0%) vs baseline: ~same

Memory: ✅ 58.629MB (SLO: <60.000MB -2.3%) vs baseline: +4.7%

✅ tracer-enabled

Time: ✅ 2.070ms (SLO: <2.250ms -8.0%) vs baseline: +0.3%

Memory: ✅ 52.160MB (SLO: <54.500MB -4.3%) vs baseline: +4.8%

✅ httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 81.627µs (SLO: <100.000µs 📉 -18.4%) vs baseline: +0.3%

Memory: ✅ 32.126MB (SLO: <33.500MB -4.1%) vs baseline: +4.6%

✅ b3_headers

Time: ✅ 14.281µs (SLO: <20.000µs 📉 -28.6%) vs baseline: +1.3%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ b3_single_headers

Time: ✅ 13.439µs (SLO: <20.000µs 📉 -32.8%) vs baseline: +1.7%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 63.982µs (SLO: <80.000µs 📉 -20.0%) vs baseline: +0.3%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 66.072µs (SLO: <80.000µs 📉 -17.4%) vs baseline: ~same

Memory: ✅ 32.126MB (SLO: <33.500MB -4.1%) vs baseline: +4.7%

✅ empty_headers

Time: ✅ 1.610µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.6%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ full_t_id_datadog_headers

Time: ✅ 22.807µs (SLO: <30.000µs 📉 -24.0%) vs baseline: -0.3%

Memory: ✅ 32.126MB (SLO: <33.500MB -4.1%) vs baseline: +4.6%

✅ invalid_priority_header

Time: ✅ 6.551µs (SLO: <10.000µs 📉 -34.5%) vs baseline: +0.6%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +5.1%

✅ invalid_span_id_header

Time: ✅ 6.564µs (SLO: <10.000µs 📉 -34.4%) vs baseline: +0.2%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +5.2%

✅ invalid_tags_header

Time: ✅ 6.568µs (SLO: <10.000µs 📉 -34.3%) vs baseline: +0.8%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +5.1%

✅ invalid_trace_id_header

Time: ✅ 6.609µs (SLO: <10.000µs 📉 -33.9%) vs baseline: +0.4%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +5.0%

✅ large_header_no_matches

Time: ✅ 27.654µs (SLO: <30.000µs -7.8%) vs baseline: +0.7%

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.8%

✅ large_valid_headers_all

Time: ✅ 28.637µs (SLO: <40.000µs 📉 -28.4%) vs baseline: -0.2%

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.6%

✅ medium_header_no_matches

Time: ✅ 9.890µs (SLO: <20.000µs 📉 -50.6%) vs baseline: +1.2%

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ medium_valid_headers_all

Time: ✅ 11.240µs (SLO: <20.000µs 📉 -43.8%) vs baseline: ~same

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.6%

✅ none_propagation_style

Time: ✅ 1.716µs (SLO: <10.000µs 📉 -82.8%) vs baseline: +1.4%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ tracecontext_headers

Time: ✅ 34.464µs (SLO: <40.000µs 📉 -13.8%) vs baseline: -0.2%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.1%

✅ valid_headers_all

Time: ✅ 6.562µs (SLO: <10.000µs 📉 -34.4%) vs baseline: +0.9%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +5.0%

✅ valid_headers_basic

Time: ✅ 6.160µs (SLO: <10.000µs 📉 -38.4%) vs baseline: +1.0%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ wsgi_empty_headers

Time: ✅ 1.597µs (SLO: <10.000µs 📉 -84.0%) vs baseline: ~same

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_invalid_priority_header

Time: ✅ 6.601µs (SLO: <10.000µs 📉 -34.0%) vs baseline: +0.1%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ wsgi_invalid_span_id_header

Time: ✅ 1.592µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.3%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_invalid_tags_header

Time: ✅ 6.616µs (SLO: <10.000µs 📉 -33.8%) vs baseline: +1.0%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.1%

✅ wsgi_invalid_trace_id_header

Time: ✅ 6.605µs (SLO: <10.000µs 📉 -33.9%) vs baseline: +0.6%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ wsgi_large_header_no_matches

Time: ✅ 28.672µs (SLO: <40.000µs 📉 -28.3%) vs baseline: -0.2%

Memory: ✅ 32.126MB (SLO: <33.500MB -4.1%) vs baseline: +4.5%

✅ wsgi_large_valid_headers_all

Time: ✅ 29.871µs (SLO: <40.000µs 📉 -25.3%) vs baseline: +0.3%

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ wsgi_medium_header_no_matches

Time: ✅ 10.251µs (SLO: <20.000µs 📉 -48.7%) vs baseline: +0.2%

Memory: ✅ 32.126MB (SLO: <33.500MB -4.1%) vs baseline: +4.5%

✅ wsgi_medium_valid_headers_all

Time: ✅ 11.604µs (SLO: <20.000µs 📉 -42.0%) vs baseline: ~same

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +5.1%

✅ wsgi_valid_headers_all

Time: ✅ 6.605µs (SLO: <10.000µs 📉 -33.9%) vs baseline: +0.2%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ wsgi_valid_headers_basic

Time: ✅ 6.154µs (SLO: <10.000µs 📉 -38.5%) vs baseline: +0.8%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.8%

✅ httppropagationinject - 16/16

✅ ids_only

Time: ✅ 21.821µs (SLO: <30.000µs 📉 -27.3%) vs baseline: ~same

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ with_all

Time: ✅ 29.033µs (SLO: <40.000µs 📉 -27.4%) vs baseline: -0.5%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ with_dd_origin

Time: ✅ 25.487µs (SLO: <30.000µs 📉 -15.0%) vs baseline: -0.2%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +5.1%

✅ with_priority_and_origin

Time: ✅ 24.741µs (SLO: <40.000µs 📉 -38.1%) vs baseline: -0.3%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.1%

✅ with_sampling_priority

Time: ✅ 21.591µs (SLO: <30.000µs 📉 -28.0%) vs baseline: ~same

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ with_tags

Time: ✅ 27.288µs (SLO: <40.000µs 📉 -31.8%) vs baseline: +0.1%

Memory: ✅ 32.106MB (SLO: <33.500MB -4.2%) vs baseline: +4.7%

✅ with_tags_invalid

Time: ✅ 28.724µs (SLO: <40.000µs 📉 -28.2%) vs baseline: +0.6%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ with_tags_max_size

Time: ✅ 27.624µs (SLO: <40.000µs 📉 -30.9%) vs baseline: ~same

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +5.0%

✅ iast_aspects - 40/40

✅ re_expand_aspect

Time: ✅ 31.988µs (SLO: <40.000µs 📉 -20.0%) vs baseline: +0.8%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ re_expand_noaspect

Time: ✅ 28.844µs (SLO: <40.000µs 📉 -27.9%) vs baseline: +1.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ re_findall_aspect

Time: ✅ 2.925µs (SLO: <10.000µs 📉 -70.8%) vs baseline: +0.8%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ re_findall_noaspect

Time: ✅ 1.431µs (SLO: <10.000µs 📉 -85.7%) vs baseline: +0.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_finditer_aspect

Time: ✅ 4.481µs (SLO: <10.000µs 📉 -55.2%) vs baseline: ~same

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_finditer_noaspect

Time: ✅ 1.407µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.5%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ re_fullmatch_aspect

Time: ✅ 2.696µs (SLO: <10.000µs 📉 -73.0%) vs baseline: -0.5%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ re_fullmatch_noaspect

Time: ✅ 1.295µs (SLO: <10.000µs 📉 -87.1%) vs baseline: ~same

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ re_group_aspect

Time: ✅ 2.970µs (SLO: <10.000µs 📉 -70.3%) vs baseline: +1.6%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_group_noaspect

Time: ✅ 1.627µs (SLO: <10.000µs 📉 -83.7%) vs baseline: +0.8%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_groups_aspect

Time: ✅ 3.113µs (SLO: <10.000µs 📉 -68.9%) vs baseline: +1.0%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ re_groups_noaspect

Time: ✅ 1.717µs (SLO: <10.000µs 📉 -82.8%) vs baseline: +1.4%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_match_aspect

Time: ✅ 2.735µs (SLO: <10.000µs 📉 -72.7%) vs baseline: +0.2%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ re_match_noaspect

Time: ✅ 1.305µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +0.4%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ re_search_aspect

Time: ✅ 2.568µs (SLO: <10.000µs 📉 -74.3%) vs baseline: -0.9%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_search_noaspect

Time: ✅ 1.201µs (SLO: <10.000µs 📉 -88.0%) vs baseline: -0.4%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ re_sub_aspect

Time: ✅ 3.453µs (SLO: <10.000µs 📉 -65.5%) vs baseline: +0.6%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ re_sub_noaspect

Time: ✅ 1.542µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -0.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ re_subn_aspect

Time: ✅ 3.659µs (SLO: <10.000µs 📉 -63.4%) vs baseline: +1.1%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ re_subn_noaspect

Time: ✅ 1.622µs (SLO: <10.000µs 📉 -83.8%) vs baseline: -0.5%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ iastaspects - 118/118

✅ add_aspect

Time: ✅ 0.409µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.8%

Memory: ✅ 37.945MB (SLO: <39.000MB -2.7%) vs baseline: +4.4%

✅ add_inplace_aspect

Time: ✅ 0.408µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.3%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ add_inplace_noaspect

Time: ✅ 0.312µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -2.3%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ add_noaspect

Time: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.2%

Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7%

✅ bytearray_aspect

Time: ✅ 1.325µs (SLO: <10.000µs 📉 -86.7%) vs baseline: -0.3%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ bytearray_extend_aspect

Time: ✅ 1.466µs (SLO: <10.000µs 📉 -85.3%) vs baseline: +0.1%

Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.9%

✅ bytearray_extend_noaspect

Time: ✅ 0.611µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.8%

Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.1%

✅ bytearray_noaspect

Time: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.6%

Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7%

✅ bytes_aspect

Time: ✅ 1.321µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +3.4%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ bytes_noaspect

Time: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.4%

Memory: ✅ 38.004MB (SLO: <39.000MB -2.6%) vs baseline: +4.9%

✅ bytesio_aspect

Time: ✅ 1.380µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +1.0%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0%

✅ bytesio_noaspect

Time: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.3%

Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.9%

✅ capitalize_aspect

Time: ✅ 0.731µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.7%

Memory: ✅ 37.985MB (SLO: <39.000MB -2.6%) vs baseline: +4.6%

✅ capitalize_noaspect

Time: ✅ 0.439µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +1.0%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ casefold_aspect

Time: ✅ 0.730µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.9%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.1%

✅ casefold_noaspect

Time: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.6%

Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.9%

✅ decode_aspect

Time: ✅ 0.728µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.9%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ decode_noaspect

Time: ✅ 0.416µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.8%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.2%

✅ encode_aspect

Time: ✅ 0.703µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.7%

Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7%

✅ encode_noaspect

Time: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.7%

Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7%

✅ format_aspect

Time: ✅ 3.375µs (SLO: <10.000µs 📉 -66.3%) vs baseline: ~same

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +3.6%

✅ format_map_aspect

Time: ✅ 3.626µs (SLO: <10.000µs 📉 -63.7%) vs baseline: +0.3%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +3.7%

✅ format_map_noaspect

Time: ✅ 0.775µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.2%

Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.1%

✅ format_noaspect

Time: ✅ 0.594µs (SLO: <10.000µs 📉 -94.1%) vs baseline: ~same

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.0%

✅ index_aspect

Time: ✅ 0.362µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +1.1%

Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.9%

✅ index_noaspect

Time: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.9%

Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.8%

✅ join_aspect

Time: ✅ 1.393µs (SLO: <10.000µs 📉 -86.1%) vs baseline: -0.7%

Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.9%

✅ join_noaspect

Time: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.3%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +5.0%

✅ ljust_aspect

Time: ✅ 2.464µs (SLO: <20.000µs 📉 -87.7%) vs baseline: -0.4%

Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +3.9%

✅ ljust_noaspect

Time: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.2%

Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.8%

✅ lower_aspect

Time: ✅ 2.194µs (SLO: <10.000µs 📉 -78.1%) vs baseline: -0.6%

Memory: ✅ 37.867MB (SLO: <39.000MB -2.9%) vs baseline: +4.3%

✅ lower_noaspect

Time: ✅ 0.364µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -1.6%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.1%

✅ lstrip_aspect

Time: ✅ 2.251µs (SLO: <20.000µs 📉 -88.7%) vs baseline: -0.4%

Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.2%

✅ lstrip_noaspect

Time: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -2.5%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7%

✅ modulo_aspect

Time: ✅ 1.022µs (SLO: <10.000µs 📉 -89.8%) vs baseline: +2.7%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7%

✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 1.526µs (SLO: <10.000µs 📉 -84.7%) vs baseline: -0.6%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ modulo_aspect_for_bytes

Time: ✅ 0.980µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.5%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.1%

✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 1.208µs (SLO: <10.000µs 📉 -87.9%) vs baseline: +0.6%

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ modulo_noaspect

Time: ✅ 0.626µs (SLO: <10.000µs 📉 -93.7%) vs baseline: ~same

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.0%

✅ replace_aspect

Time: ✅ 4.746µs (SLO: <10.000µs 📉 -52.5%) vs baseline: -1.9%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +3.8%

✅ replace_noaspect

Time: ✅ 0.458µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.7%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ repr_aspect

Time: ✅ 0.913µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.5%

Memory: ✅ 37.985MB (SLO: <39.000MB -2.6%) vs baseline: +4.6%

✅ repr_noaspect

Time: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +1.2%

Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.8%

✅ rstrip_aspect

Time: ✅ 1.925µs (SLO: <20.000µs 📉 -90.4%) vs baseline: +0.1%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +3.9%

✅ rstrip_noaspect

Time: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.2%

Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7%

✅ slice_aspect

Time: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.1%

Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.8%

✅ slice_noaspect

Time: ✅ 0.441µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -2.4%

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ stringio_aspect

Time: ✅ 1.554µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.9%

Memory: ✅ 37.906MB (SLO: <39.000MB -2.8%) vs baseline: +4.4%

✅ stringio_noaspect

Time: ✅ 0.715µs (SLO: <10.000µs 📉 -92.8%) vs baseline: ~same

Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9%

✅ strip_aspect

Time: ✅ 2.246µs (SLO: <20.000µs 📉 -88.8%) vs baseline: -0.2%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.0%

✅ strip_noaspect

Time: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.8%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8%

✅ swapcase_aspect

Time: ✅ 2.401µs (SLO: <10.000µs 📉 -76.0%) vs baseline: -1.1%

Memory: ✅ 37.906MB (SLO: <39.000MB -2.8%) vs baseline: +4.5%

✅ swapcase_noaspect

Time: ✅ 0.533µs (SLO: <10.000µs 📉 -94.7%) vs baseline: ~same

Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9%

✅ title_aspect

Time: ✅ 2.354µs (SLO: <10.000µs 📉 -76.5%) vs baseline: -0.1%

Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.0%

✅ title_noaspect

Time: ✅ 0.507µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +1.4%

Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.1%

✅ translate_aspect

Time: ✅ 3.206µs (SLO: <10.000µs 📉 -67.9%) vs baseline: -0.4%

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.2%

✅ translate_noaspect

Time: ✅ 1.040µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.2%

Memory: ✅ 37.985MB (SLO: <39.000MB -2.6%) vs baseline: +4.5%

✅ upper_aspect

Time: ✅ 2.208µs (SLO: <10.000µs 📉 -77.9%) vs baseline: -1.2%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.3%

✅ upper_noaspect

Time: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5%

Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7%

✅ iastaspectsospath - 24/24

✅ ospathbasename_aspect

Time: ✅ 4.380µs (SLO: <10.000µs 📉 -56.2%) vs baseline: +0.4%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ ospathbasename_noaspect

Time: ✅ 1.091µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +0.3%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ ospathjoin_aspect

Time: ✅ 6.183µs (SLO: <10.000µs 📉 -38.2%) vs baseline: +1.0%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ ospathjoin_noaspect

Time: ✅ 2.319µs (SLO: <10.000µs 📉 -76.8%) vs baseline: +0.6%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7%

✅ ospathnormcase_aspect

Time: ✅ 3.525µs (SLO: <10.000µs 📉 -64.8%) vs baseline: +0.8%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ ospathnormcase_noaspect

Time: ✅ 0.576µs (SLO: <10.000µs 📉 -94.2%) vs baseline: ~same

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.6%

✅ ospathsplit_aspect

Time: ✅ 4.995µs (SLO: <10.000µs 📉 -50.0%) vs baseline: +1.8%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ ospathsplit_noaspect

Time: ✅ 1.597µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.6%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ ospathsplitdrive_aspect

Time: ✅ 3.696µs (SLO: <10.000µs 📉 -63.0%) vs baseline: +1.0%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ ospathsplitdrive_noaspect

Time: ✅ 0.698µs (SLO: <10.000µs 📉 -93.0%) vs baseline: ~same

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ ospathsplitext_aspect

Time: ✅ 4.868µs (SLO: <10.000µs 📉 -51.3%) vs baseline: +6.7%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ ospathsplitext_noaspect

Time: ✅ 1.395µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.1%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ iastaspectssplit - 12/12

✅ rsplit_aspect

Time: ✅ 1.439µs (SLO: <10.000µs 📉 -85.6%) vs baseline: -0.8%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ rsplit_noaspect

Time: ✅ 0.577µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -1.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ split_aspect

Time: ✅ 1.429µs (SLO: <10.000µs 📉 -85.7%) vs baseline: -1.3%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6%

✅ split_noaspect

Time: ✅ 0.572µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.8%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ splitlines_aspect

Time: ✅ 1.412µs (SLO: <10.000µs 📉 -85.9%) vs baseline: +0.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ splitlines_noaspect

Time: ✅ 0.584µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +0.5%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ iastpropagation - 2/2

✅ no-propagation

Time: ✅ 49.383µs (SLO: <60.000µs 📉 -17.7%) vs baseline: +0.2%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.655ms (SLO: <42.000ms -3.2%) vs baseline: +0.8%

Memory: ✅ 34.583MB (SLO: <39.000MB 📉 -11.3%) vs baseline: +4.9%

✅ add-link

Time: ✅ 36.417ms (SLO: <38.550ms -5.5%) vs baseline: +0.2%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.9%

✅ add-metrics

Time: ✅ 220.496ms (SLO: <232.000ms -5.0%) vs baseline: +0.1%

Memory: ✅ 34.583MB (SLO: <39.000MB 📉 -11.3%) vs baseline: +4.1%

✅ add-tags

Time: ✅ 211.432ms (SLO: <221.600ms -4.6%) vs baseline: -0.4%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.8%

✅ get-context

Time: ✅ 29.338ms (SLO: <31.300ms -6.3%) vs baseline: +1.0%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +5.0%

✅ is-recording

Time: ✅ 29.151ms (SLO: <31.000ms -6.0%) vs baseline: -0.3%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.8%

✅ record-exception

Time: ✅ 62.957ms (SLO: <65.850ms -4.4%) vs baseline: ~same

Memory: ✅ 34.937MB (SLO: <39.000MB 📉 -10.4%) vs baseline: +4.8%

✅ set-status

Time: ✅ 32.089ms (SLO: <34.150ms -6.0%) vs baseline: +0.2%

Memory: ✅ 34.642MB (SLO: <39.000MB 📉 -11.2%) vs baseline: +4.7%

✅ start

Time: ✅ 28.798ms (SLO: <30.150ms -4.5%) vs baseline: -0.4%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.8%

✅ start-finish

Time: ✅ 33.922ms (SLO: <35.350ms -4.0%) vs baseline: -0.4%

Memory: ✅ 34.682MB (SLO: <39.000MB 📉 -11.1%) vs baseline: +5.2%

✅ start-finish-telemetry

Time: ✅ 33.941ms (SLO: <35.450ms -4.3%) vs baseline: +0.4%

Memory: ✅ 34.524MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.7%

✅ update-name

Time: ✅ 31.225ms (SLO: <33.400ms -6.5%) vs baseline: +0.7%

Memory: ✅ 34.642MB (SLO: <39.000MB 📉 -11.2%) vs baseline: +4.7%

✅ packagespackageforrootmodulemapping - 4/4

✅ cache_off

Time: ✅ 341.421ms (SLO: <354.300ms -3.6%) vs baseline: -1.1%

Memory: ✅ 37.862MB (SLO: <40.000MB -5.3%) vs baseline: +2.8%

✅ cache_on

Time: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.3%

Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.4%

✅ packagesupdateimporteddependencies - 24/24

✅ import_many

Time: ✅ 154.969µs (SLO: <170.000µs -8.8%) vs baseline: +0.4%

Memory: ✅ 36.985MB (SLO: <38.500MB -3.9%) vs baseline: +4.9%

✅ import_many_cached

Time: ✅ 120.591µs (SLO: <130.000µs -7.2%) vs baseline: -0.4%

Memory: ✅ 36.894MB (SLO: <38.500MB -4.2%) vs baseline: +4.5%

✅ import_many_stdlib

Time: ✅ 1.627ms (SLO: <1.750ms -7.1%) vs baseline: -0.2%

Memory: ✅ 37.562MB (SLO: <38.500MB -2.4%) vs baseline: +6.0%

✅ import_many_stdlib_cached

Time: ✅ 0.978ms (SLO: <1.100ms 📉 -11.1%) vs baseline: -0.2%

Memory: ✅ 37.076MB (SLO: <38.500MB -3.7%) vs baseline: +4.4%

✅ import_many_unknown

Time: ✅ 829.606µs (SLO: <890.000µs -6.8%) vs baseline: +0.4%

Memory: ✅ 37.131MB (SLO: <38.500MB -3.6%) vs baseline: +4.8%

✅ import_many_unknown_cached

Time: ✅ 794.942µs (SLO: <870.000µs -8.6%) vs baseline: +0.3%

Memory: ✅ 36.978MB (SLO: <38.500MB -4.0%) vs baseline: +4.3%

✅ import_one

Time: ✅ 19.750µs (SLO: <30.000µs 📉 -34.2%) vs baseline: -0.4%

Memory: ✅ 37.715MB (SLO: <39.000MB -3.3%) vs baseline: +6.8%

✅ import_one_cache

Time: ✅ 6.363µs (SLO: <10.000µs 📉 -36.4%) vs baseline: +1.2%

Memory: ✅ 36.950MB (SLO: <38.500MB -4.0%) vs baseline: +4.9%

✅ import_one_stdlib

Time: ✅ 18.705µs (SLO: <20.000µs -6.5%) vs baseline: +0.2%

Memory: ✅ 36.926MB (SLO: <38.500MB -4.1%) vs baseline: +4.7%

✅ import_one_stdlib_cache

Time: ✅ 6.289µs (SLO: <10.000µs 📉 -37.1%) vs baseline: +0.3%

Memory: ✅ 36.941MB (SLO: <38.500MB -4.0%) vs baseline: +4.1%

✅ import_one_unknown

Time: ✅ 45.546µs (SLO: <50.000µs -8.9%) vs baseline: -0.5%

Memory: ✅ 36.981MB (SLO: <38.500MB -3.9%) vs baseline: +5.2%

✅ import_one_unknown_cache

Time: ✅ 6.261µs (SLO: <10.000µs 📉 -37.4%) vs baseline: -0.1%

Memory: ✅ 36.967MB (SLO: <38.500MB -4.0%) vs baseline: +4.0%

✅ ratelimiter - 12/12

✅ defaults

Time: ✅ 2.364µs (SLO: <10.000µs 📉 -76.4%) vs baseline: +0.2%

Memory: ✅ 31.792MB (SLO: <34.000MB -6.5%) vs baseline: +4.9%

✅ high_rate_limit

Time: ✅ 2.404µs (SLO: <10.000µs 📉 -76.0%) vs baseline: ~same

Memory: ✅ 31.733MB (SLO: <34.000MB -6.7%) vs baseline: +4.6%

✅ long_window

Time: ✅ 2.342µs (SLO: <10.000µs 📉 -76.6%) vs baseline: -0.9%

Memory: ✅ 31.772MB (SLO: <34.000MB -6.6%) vs baseline: +4.8%

✅ low_rate_limit

Time: ✅ 2.350µs (SLO: <10.000µs 📉 -76.5%) vs baseline: -0.8%

Memory: ✅ 31.792MB (SLO: <34.000MB -6.5%) vs baseline: +4.9%

✅ no_rate_limit

Time: ✅ 0.825µs (SLO: <10.000µs 📉 -91.7%) vs baseline: -0.3%

Memory: ✅ 31.811MB (SLO: <34.000MB -6.4%) vs baseline: +5.1%

✅ short_window

Time: ✅ 2.499µs (SLO: <10.000µs 📉 -75.0%) vs baseline: ~same

Memory: ✅ 31.831MB (SLO: <34.000MB -6.4%) vs baseline: +5.1%

✅ recursivecomputation - 8/8

✅ deep

Time: ✅ 308.475ms (SLO: <320.950ms -3.9%) vs baseline: -0.1%

Memory: ✅ 32.912MB (SLO: <34.500MB -4.6%) vs baseline: +4.9%

✅ deep-profiled

Time: ✅ 326.121ms (SLO: <359.150ms -9.2%) vs baseline: ~same

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.8%

✅ medium

Time: ✅ 7.096ms (SLO: <7.400ms -4.1%) vs baseline: ~same

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7%

✅ shallow

Time: ✅ 0.965ms (SLO: <1.050ms -8.1%) vs baseline: +1.1%

Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.0%

✅ samplingrules - 8/8

✅ average_match

Time: ✅ 148.448µs (SLO: <290.000µs 📉 -48.8%) vs baseline: ~same

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.1%

✅ high_match

Time: ✅ 193.966µs (SLO: <480.000µs 📉 -59.6%) vs baseline: -0.1%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9%

✅ low_match

Time: ✅ 99.982µs (SLO: <120.000µs 📉 -16.7%) vs baseline: ~same

Memory: ✅ 632.652MB (SLO: <700.000MB -9.6%) vs baseline: +4.9%

✅ very_low_match

Time: ✅ 2.886ms (SLO: <8.500ms 📉 -66.0%) vs baseline: ~same

Memory: ✅ 70.311MB (SLO: <75.000MB -6.3%) vs baseline: +4.8%

✅ sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.514µs (SLO: <20.000µs 📉 -47.4%) vs baseline: +0.3%

Memory: ✅ 32.617MB (SLO: <34.000MB -4.1%) vs baseline: +5.2%

✅ all-enabled

Time: ✅ 39.822µs (SLO: <50.000µs 📉 -20.4%) vs baseline: -0.2%

Memory: ✅ 32.637MB (SLO: <34.000MB -4.0%) vs baseline: +5.0%

✅ collectipvariant_exists

Time: ✅ 40.702µs (SLO: <50.000µs 📉 -18.6%) vs baseline: +0.2%

Memory: ✅ 32.637MB (SLO: <34.000MB -4.0%) vs baseline: +4.9%

✅ no-collectipvariant

Time: ✅ 39.876µs (SLO: <50.000µs 📉 -20.2%) vs baseline: ~same

Memory: ✅ 32.539MB (SLO: <34.000MB -4.3%) vs baseline: +4.8%

✅ no-useragentvariant

Time: ✅ 38.546µs (SLO: <50.000µs 📉 -22.9%) vs baseline: +0.2%

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +4.9%

✅ obfuscation-no-query

Time: ✅ 40.602µs (SLO: <50.000µs 📉 -18.8%) vs baseline: +0.8%

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +5.0%

✅ obfuscation-regular-case-explicit-query

Time: ✅ 75.531µs (SLO: <90.000µs 📉 -16.1%) vs baseline: -0.2%

Memory: ✅ 32.932MB (SLO: <34.000MB -3.1%) vs baseline: +4.7%

✅ obfuscation-regular-case-implicit-query

Time: ✅ 76.109µs (SLO: <90.000µs 📉 -15.4%) vs baseline: ~same

Memory: ✅ 32.991MB (SLO: <34.000MB -3.0%) vs baseline: +4.9%

✅ obfuscation-send-querystring-disabled

Time: ✅ 153.836µs (SLO: <170.000µs -9.5%) vs baseline: -0.2%

Memory: ✅ 33.010MB (SLO: <34.500MB -4.3%) vs baseline: +4.9%

✅ obfuscation-worst-case-explicit-query

Time: ✅ 148.241µs (SLO: <160.000µs -7.3%) vs baseline: +0.1%

Memory: ✅ 32.971MB (SLO: <34.500MB -4.4%) vs baseline: +4.7%

✅ obfuscation-worst-case-implicit-query

Time: ✅ 154.321µs (SLO: <170.000µs -9.2%) vs baseline: ~same

Memory: ✅ 32.991MB (SLO: <34.500MB -4.4%) vs baseline: +4.8%

✅ useragentvariant_exists_1

Time: ✅ 39.572µs (SLO: <50.000µs 📉 -20.9%) vs baseline: +0.6%

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +4.8%

✅ useragentvariant_exists_2

Time: ✅ 40.407µs (SLO: <50.000µs 📉 -19.2%) vs baseline: ~same

Memory: ✅ 32.617MB (SLO: <34.000MB -4.1%) vs baseline: +4.8%

✅ useragentvariant_exists_3

Time: ✅ 40.069µs (SLO: <50.000µs 📉 -19.9%) vs baseline: +0.9%

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +4.9%

✅ useragentvariant_not_exists_1

Time: ✅ 39.509µs (SLO: <50.000µs 📉 -21.0%) vs baseline: +0.7%

Memory: ✅ 32.598MB (SLO: <34.000MB -4.1%) vs baseline: +4.8%

✅ useragentvariant_not_exists_2

Time: ✅ 39.533µs (SLO: <50.000µs 📉 -20.9%) vs baseline: +0.7%

Memory: ✅ 32.558MB (SLO: <34.000MB -4.2%) vs baseline: +4.7%

✅ telemetryaddmetric - 30/30

✅ 1-count-metric-1-times

Time: ✅ 3.149µs (SLO: <20.000µs 📉 -84.3%) vs baseline: +2.9%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7%

✅ 1-count-metrics-100-times

Time: ✅ 212.102µs (SLO: <250.000µs 📉 -15.2%) vs baseline: +0.6%

Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.5%

✅ 1-distribution-metric-1-times

Time: ✅ 2.937µs (SLO: <20.000µs 📉 -85.3%) vs baseline: +0.9%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.0%

✅ 1-distribution-metrics-100-times

Time: ✅ 190.814µs (SLO: <220.000µs 📉 -13.3%) vs baseline: +0.4%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.1%

✅ 1-gauge-metric-1-times

Time: ✅ 2.143µs (SLO: <20.000µs 📉 -89.3%) vs baseline: +4.1%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ 1-gauge-metrics-100-times

Time: ✅ 123.958µs (SLO: <150.000µs 📉 -17.4%) vs baseline: ~same

Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.0%

✅ 1-rate-metric-1-times

Time: ✅ 3.200µs (SLO: <20.000µs 📉 -84.0%) vs baseline: +3.1%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ 1-rate-metrics-100-times

Time: ✅ 212.407µs (SLO: <250.000µs 📉 -15.0%) vs baseline: +0.3%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.0%

✅ 100-count-metrics-100-times

Time: ✅ 21.311ms (SLO: <23.500ms -9.3%) vs baseline: -0.1%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.8%

✅ 100-distribution-metrics-100-times

Time: ✅ 1.984ms (SLO: <2.250ms 📉 -11.8%) vs baseline: +0.2%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.9%

✅ 100-gauge-metrics-100-times

Time: ✅ 1.291ms (SLO: <1.550ms 📉 -16.7%) vs baseline: +0.3%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ 100-rate-metrics-100-times

Time: ✅ 2.194ms (SLO: <2.550ms 📉 -14.0%) vs baseline: +1.0%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9%

✅ flush-1-metric

Time: ✅ 4.308µs (SLO: <20.000µs 📉 -78.5%) vs baseline: +0.7%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.2%

✅ flush-100-metrics

Time: ✅ 184.224µs (SLO: <250.000µs 📉 -26.3%) vs baseline: +1.8%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.0%

✅ flush-1000-metrics

Time: ✅ 2.248ms (SLO: <2.500ms 📉 -10.1%) vs baseline: +2.0%

Memory: ✅ 32.893MB (SLO: <34.500MB -4.7%) vs baseline: +4.8%

✅ tracer - 6/6

✅ large

Time: ✅ 30.282ms (SLO: <32.950ms -8.1%) vs baseline: ~same

Memory: ✅ 33.325MB (SLO: <34.500MB -3.4%) vs baseline: +5.0%

✅ medium

Time: ✅ 2.998ms (SLO: <3.200ms -6.3%) vs baseline: +1.0%

Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +4.5%

✅ small

Time: ✅ 335.499µs (SLO: <370.000µs -9.3%) vs baseline: +0.1%

Memory: ✅ 31.713MB (SLO: <34.000MB -6.7%) vs baseline: +3.6%

ℹ️ Scenarios Missing SLO Configuration (9 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

coreapiscenario-core_dispatch_listeners
coreapiscenario-core_dispatch_no_listeners
coreapiscenario-core_dispatch_with_results_listeners
coreapiscenario-core_dispatch_with_results_no_listeners
djangosimple-baseline
errortrackingdjangosimple-baseline
errortrackingflasksqli-baseline
flasksimple-baseline
flasksqli-baseline

tests/profiling_v2/test_profiler.py

tests/profiling_v2/collector/test_threading.py

…lector tests fail

…belong with threading)

taegyunkim

One worry i had in mind when doing something similar to this was the fact that some threading classes (Condition, Event) internally use Lock(). Fortunately, RLock doesn't use it and use _allocate_lock() to create its internal lock instance.

For Condition and Event, how do you plan to implement the profiler?

ddtrace/profiling/collector/threading.py

ddtrace/profiling/profiler.py

tests/profiling_v2/test_rlock_e2e.py

Co-authored-by: Taegyun Kim <[email protected]>

vlad-scherbich · 2025-10-15T14:59:55Z

One worry i had in mind when doing something similar to this was the fact that some threading classes (Condition, Event) internally use Lock().

Can you share an example of something concerning about this fact? In my view, this is actually a desired effect: complex primitives that use Lock in their implementation, such as Condition and Event, should correctly attribute time spent creating / calling both complex and simple primitives (e.g. by including the calls Lock when creating their underlying class members.)

For Condition and Event, how do you plan to implement the profiler?

I'm still fleshing this out, but given the above statement, I plan to modify _ProfiledLock c-tor so that self._self_init_loc is assigned the actual primitive information, such as: its name and file-lineno.

Example:

cv = threading.Condition()  # app.py:50

cv.wait()    # app.py:75
cv.wait()    # app.py:120
cv.notify()  # app.py:90

Option 1
Would produce something like:

Condition[app.py:50:cv]._lock.wait()@app.py:75
Condition[app.py:50:cv]._lock.wait()@app.py:120
Condition[app.py:50:cv]._lock.notify()@app.py:90

, where [app.py:50:cv] denotes lock creation line, and wait()@app.py:75 shows operation line.

Option 1

In fact, this approach should work for all of the complex primitives that are implemented with either Lock or RLock. As for instrumenting complex primitives' unique methods, such as wait, etc.: it does not seem necessary on the first pass. I think that work should be done in separate PR(s).

Notes
Types implementing Lock (directly and by extension)

Condition --> Lock()
Semaphore --> Condition(Lock)
Event --> Condition(Lock)
Barrier --> Condition(Lock)

Types implementing RLock

Condition

taegyunkim

The PR looks mostly good.

One thing to check

How these samples/events would show up on the timeline viz
https://www.datadoghq.com/blog/continuous-profiler-timeline-view/

vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 2 times, most recently from 944b340 to c17cd90 Compare October 9, 2025 03:00

vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 3 times, most recently from 195b3c8 to 22f1608 Compare October 10, 2025 18:34

vlad-scherbich changed the title ~~Vlad/lock profiler add rlock~~ feature(profiling): add Reentrant Lock (RLock) support to the Lock profiler Oct 10, 2025

vlad-scherbich changed the title ~~feature(profiling): add Reentrant Lock (RLock) support to the Lock profiler~~ feat(profiling): add Reentrant Lock (RLock) support to the Lock profiler Oct 10, 2025

vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 3 times, most recently from cbe5cdd to a7fb6e2 Compare October 10, 2025 22:11

vlad-scherbich requested a review from danielsn October 10, 2025 22:16

vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 2 times, most recently from 0520a6b to 4c62a2c Compare October 10, 2025 22:32

vlad-scherbich marked this pull request as ready for review October 10, 2025 22:57

vlad-scherbich requested review from a team as code owners October 10, 2025 22:57

vlad-scherbich requested review from mabdinur and wconti27 October 10, 2025 22:57

vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 2 times, most recently from 79da982 to 3f50634 Compare October 14, 2025 09:50

vlad-scherbich marked this pull request as draft October 14, 2025 10:03

vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch from 3f50634 to 7e7549f Compare October 14, 2025 14:55

vlad-scherbich commented Oct 14, 2025

View reviewed changes

tests/profiling_v2/test_profiler.py Show resolved Hide resolved

tests/profiling_v2/collector/test_threading.py Show resolved Hide resolved

vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch 2 times, most recently from 435e9ec to 5faff64 Compare October 14, 2025 16:08

vlad-scherbich marked this pull request as ready for review October 14, 2025 16:45

emmettbutler approved these changes Oct 14, 2025

View reviewed changes

vlad-scherbich added 18 commits October 15, 2025 11:12

feat(profiling): add 'threading.RLock' support to the Lock profiler

97e853d

add RLock tests

5e8dfa3

all TestThreadingLockCollector tests pass; some TestThreadingRLockCol…

fc69a7e

…lector tests fail

some still don't pass; most pass; flaky?

11cf283

fix lints

6c81bf6

rm unnecessary 'pass'

420737b

fix test_global_locks test

4c358c9

Simplified and improve: fix test_global_locks test

7040206

lint fixes

90f1cbc

fix line-number discrepancy for py versions

a5bca10

Add a release note

ef1bc8b

add e2e test

70295e5

fix lint

9287d1e

move the e2e test file into tests dir

4a011aa

adding more tests

f0222bc

Moving test_user_threads_have_native_id to test_profiler (it doesn't …

ec0285c

…belong with threading)

Clean up 'test_[r|]lock_gevent_tasks' tests

400205b

fix tests (import threading)

259091d

vlad-scherbich force-pushed the vlad/lock-profiler-add-rlock branch from 5faff64 to 259091d Compare October 15, 2025 09:14

taegyunkim reviewed Oct 15, 2025

View reviewed changes

vlad-scherbich and others added 3 commits October 15, 2025 07:04

Update ddtrace/profiling/collector/threading.py

8393b00

Co-authored-by: Taegyun Kim <[email protected]>

Update ddtrace/profiling/collector/threading.py

50f3754

Co-authored-by: Taegyun Kim <[email protected]>

fix tests and rm the e2e test file

45abc7f

vlad-scherbich changed the title ~~feat(profiling): add Reentrant Lock (RLock) support to the Lock profiler~~ feat(profiling): add threading.RLock support to the Lock profiler (re-entrant lock) Oct 16, 2025

taegyunkim approved these changes Oct 17, 2025

View reviewed changes

feat(profiling): add threading.RLock support to the Lock profiler (re-entrant lock) #14823

Are you sure you want to change the base?

feat(profiling): add threading.RLock support to the Lock profiler (re-entrant lock) #14823

Uh oh!

Conversation

vlad-scherbich commented Oct 9, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Testing

Risks

Additional Notes

Uh oh!

github-actions bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bootstrap import analysis

Summary

Import time breakdown

Uh oh!

pr-commenter bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance SLOs

✅ appsec

✅ exception-replay-enabled

✅ iast

✅ profiler

✅ resource-renaming

✅ span-code-origin

✅ tracer

✅ tracer-and-profiler

✅ tracer-dont-create-db-spans

✅ tracer-minimal

✅ tracer-native

✅ tracer-no-caches

✅ tracer-no-databases

✅ tracer-no-middleware

✅ tracer-no-templates

✅ errortracking-enabled-all

✅ errortracking-enabled-user

✅ tracer-enabled

✅ appsec-get

✅ appsec-post

✅ appsec-telemetry

✅ debugger

✅ iast-get

✅ profiler

✅ resource-renaming

✅ tracer

✅ tracer-native

✅ add-event

✅ add-metrics

✅ add-tags

✅ get-context

✅ is-recording

✅ record-exception

✅ set-status

✅ start

✅ start-finish

✅ start-finish-telemetry

✅ update-name

✅ add-event

✅ add-metrics

✅ add-tags

✅ get-context

✅ is-recording

✅ record-exception

✅ set-status

✅ start

✅ start-finish

✅ start-finish-telemetry

✅ start-finish-traceid128

✅ start-traceid128

✅ update-name

⚠️ context_with_data_listeners

✅ context_with_data_no_listeners

✅ get_item_exists

✅ get_item_missing

vlad-scherbich commented Oct 9, 2025 •

edited by atlassian bot

Loading

github-actions bot commented Oct 9, 2025 •

edited

Loading

github-actions bot commented Oct 9, 2025 •

edited

Loading

pr-commenter bot commented Oct 9, 2025 •

edited

Loading