-
Notifications
You must be signed in to change notification settings - Fork 464
feat(profiling): add threading.RLock support to the Lock profiler (re-entrant lock) #14823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+382
−190
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e000d93
feat(profiling): add 'threading.RLock' support to the Lock profiler
vlad-scherbich 2395cfc
add RLock tests
vlad-scherbich 66756d9
all TestThreadingLockCollector tests pass; some TestThreadingRLockCol…
vlad-scherbich 818e62a
some still don't pass; most pass; flaky?
vlad-scherbich 22baef3
fix lints
vlad-scherbich 5c6484c
rm unnecessary 'pass'
vlad-scherbich 93ea186
fix test_global_locks test
vlad-scherbich 8fdbd8d
Simplified and improve: fix test_global_locks test
vlad-scherbich e7e659a
lint fixes
vlad-scherbich 197f883
fix line-number discrepancy for py versions
vlad-scherbich b465fe2
Add a release note
vlad-scherbich 28dc94b
add e2e test
vlad-scherbich 7ba5c16
fix lint
vlad-scherbich fa05ae3
move the e2e test file into tests dir
vlad-scherbich 0b47089
adding more tests
vlad-scherbich 1038886
Moving test_user_threads_have_native_id to test_profiler (it doesn't …
vlad-scherbich 6c2461f
Clean up 'test_[r|]lock_gevent_tasks' tests
vlad-scherbich 7d2dcf1
fix tests (import threading)
vlad-scherbich 39bc88f
Update ddtrace/profiling/collector/threading.py
vlad-scherbich bfe6b84
Update ddtrace/profiling/collector/threading.py
vlad-scherbich f29be5c
fix tests and rm the e2e test file
vlad-scherbich 1db7591
Merge branch 'main' into vlad/lock-profiler-add-rlock
vlad-scherbich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
releasenotes/notes/feat-profiling-rlock-support-e8607e68252647.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| --- | ||
| features: | ||
| - | | ||
| profiling: Add support for ``threading.RLock`` (reentrant lock) profiling. The Lock profiler now tracks both ``threading.Lock`` and ``threading.RLock`` usage, providing comprehensive lock contention visibility for Python applications. |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.