Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(langchain): make langchain version skip conditional less precise for CI #9997

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Jul 30, 2024

Even after #9768 we're still seeing some tests be skipped on CI, specifically langchain-community tests even when langchain>=0.1. My suspicion is that the sys.version_info < (0, 1, 0) conditional that is used for the test skipping is too precise for the versions of Langchain being run on CI (not exactly sure what the issue is, but I've narrowed it down to that area). This PR only checks the major and minor version of Langchain being run

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 30, 2024
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/langchain/test_langchain_community.py                     @DataDog/ml-observability

@Yun-Kim Yun-Kim marked this pull request as ready for review July 30, 2024 20:35
@Yun-Kim Yun-Kim requested a review from a team as a code owner July 30, 2024 20:35
@Yun-Kim Yun-Kim enabled auto-merge (squash) July 30, 2024 20:36
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jul 30, 2024

Datadog Report

Branch report: yunkim/langchain-community-flaky
Commit report: 0def0a9
Test service: dd-trace-py

✅ 0 Failed, 425 Passed, 151 Skipped, 7m 36.68s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jul 30, 2024

Benchmarks

Benchmark execution time: 2024-07-30 21:45:00

Comparing candidate commit f0a29e5 in PR branch yunkim/langchain-community-flaky with baseline commit 07f0752 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 208 metrics, 2 unstable metrics.

@Yun-Kim Yun-Kim merged commit 65240c1 into main Jul 31, 2024
45 of 46 checks passed
@Yun-Kim Yun-Kim deleted the yunkim/langchain-community-flaky branch July 31, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants