[PROF-10422] Fix flaky spec in profiler due to race #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR fixes a flaky spec introduced by #3929: a spec to check that an error was raised in a background thread implicitly depended on a race (that the background thread ran before the rspec thread did) and thus started failing when the race was lost. By actually synchronizing with the background thread using the `on_failure_proc`, we now guarantee that the background thread has the chance to run as expected. **Motivation:** Our goal is to always have zero flaky specs in the profiler! **Additional Notes:** Fixes DataDog/ruby-guild#179 **How to test the change?** Validate that CI is still green.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3934 +/- ##
==========================================
+ Coverage 97.75% 97.77% +0.02%
==========================================
Files 1297 1297
Lines 77611 77973 +362
Branches 3871 3888 +17
==========================================
+ Hits 75869 76240 +371
+ Misses 1742 1733 -9 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-09-20 11:30:22 Comparing candidate commit c8d5351 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
ivoanjo
changed the title
anmarchenko
approved these changes
Sep 20, 2024
ivoanjo
added
profiling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a flaky spec introduced by #3929: a spec to check that an error was raised in a background thread implicitly depended on a race (that the background thread ran before the rspec thread did) and thus started failing when the race was lost.
By actually synchronizing with the background thread using the
on_failure_proc, we now guarantee that the background thread has the chance to run as expected.Motivation:
Our goal is to always have zero flaky specs in the profiler!
Additional Notes:
Fixes https://github.com/DataDog/ruby-guild/issues/179
How to test the change?
Validate that CI is still green.