Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-10422] Fix flaky spec in profiler due to race #3934

Merged
merged 1 commit into from
Sep 20, 2024

Commits on Sep 20, 2024

  1. [NO-TICKET] Fix flaky spec in profiler due to race

    **What does this PR do?**
    
    This PR fixes a flaky spec introduced by #3929: a spec to check that
    an error was raised in a background thread implicitly depended on a race
    (that the background thread ran before the rspec thread did) and thus
    started failing when the race was lost.
    
    By actually synchronizing with the background thread using the
    `on_failure_proc`, we now guarantee that the background thread has
    the chance to run as expected.
    
    **Motivation:**
    
    Our goal is to always have zero flaky specs in the profiler!
    
    **Additional Notes:**
    
    Fixes DataDog/ruby-guild#179
    
    **How to test the change?**
    
    Validate that CI is still green.
    ivoanjo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c8d5351 View commit details
    Browse the repository at this point in the history