Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated Signals Explorer topic with new column titles #27715

Merged

Conversation

michaelcretzman
Copy link
Contributor

@michaelcretzman michaelcretzman commented Feb 19, 2025

also covered Bulk Actions

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

also covered Bulk Actions
@michaelcretzman michaelcretzman requested a review from a team as a code owner February 19, 2025 22:30
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@michaelcretzman michaelcretzman added the editorial review Waiting on a more in-depth review label Feb 19, 2025
@michaelcretzman
Copy link
Contributor Author

Editorial review ticket:
https://datadoghq.atlassian.net/browse/DOCS-10174

Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Michael! I put in some suggestions to fix some typos, and made some comments about some spectacularly picky questions. As always, let me know if there's anything I can explain better, or when you'd like me to give it a final rubber stamp 🙂

Incorporating peer edit

Co-authored-by: Janine Chan <[email protected]>
Copy link
Contributor Author

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just making changes based on peer edit suggestions

@michaelcretzman
Copy link
Contributor Author

@janine-c thanks for the review.
If you're good with my changes, please Approve the PR.
Thanks again!

Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for your responses to my comments; those provided helpful context for my understanding of the product 💡

@michaelcretzman michaelcretzman merged commit bd69275 into master Feb 21, 2025
11 checks passed
@michaelcretzman michaelcretzman deleted the mcretzman/DOCS-9310--asm-signals-columns-update branch February 21, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants