-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated Signals Explorer topic with new column titles #27715
updated Signals Explorer topic with new column titles #27715
Conversation
also covered Bulk Actions
Preview links (active after the
|
Editorial review ticket: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Michael! I put in some suggestions to fix some typos, and made some comments about some spectacularly picky questions. As always, let me know if there's anything I can explain better, or when you'd like me to give it a final rubber stamp 🙂
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
Incorporating peer edit Co-authored-by: Janine Chan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just making changes based on peer edit suggestions
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/threats/security_signals.md
Outdated
Show resolved
Hide resolved
more peer review suggestions
…als.md Co-authored-by: Janine Chan <[email protected]>
@janine-c thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for your responses to my comments; those provided helpful context for my understanding of the product 💡
also covered Bulk Actions
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes