Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated Signals Explorer topic with new column titles #27715
updated Signals Explorer topic with new column titles #27715
Changes from 2 commits
61a566f
bdf6133
f7404d0
a16bd46
73ed1ec
e01f382
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 21 in content/en/security/application_security/threats/security_signals.md
Datadog.headings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this list supposed to include a separate step for selecting the incident commander? It feels a little odd to have an ordered list with just one item in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The substep is simply adding detail to severity level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same note as above about my concern that users might not know to click "Show all actions" to expose this section or button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not worried.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has the last section been renamed recently/is it going to be renamed imminently? I'm seeing "Detection Rule" instead of "Rule Details."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be Detection Rule. I'll fix it. Great catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to check whether "take action" is intentionally vague to let users choose their own adventure here. I can't tell if these are all options that a user could take, or if a typical user should do all of them, or if a user can choose multiple, or if they're mutually exclusive. But sometimes when course of action are vague, this is all you can really say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a subset with details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the whole permission name be bolded? It is in the UI:

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it shouldn't. The perm is Protect Write.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, there's an interesting UI quirk where if you've scrolled down the table of signals (not improbable if you're selecting multiple), you can't see the Bulk Actions button. Might be worth mentioning that it's at the top of the table? I usually don't like to do that, but I like to if I feel like I need an insurance policy against users getting lost in the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they can find it. It appears once you select a row.
Check notice on line 128 in content/en/security/application_security/threats/security_signals.md
Datadog.oxfordcomma