[SINT-2736] Support scanning github actions #526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return data, unzippedpath | ||
|
|
||
| def _parse_git_url(self, package_name: str) -> str: |
There was a problem hiding this comment.
nit: would be good to have an unit test for that one (not a blocker though)
There was a problem hiding this comment.
Good point, updated one existing (but skipped) test in b20a248.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A contribution to run NPM scans over GitHub projects.
This allows scanning Github actions which are not released on NPM but for which JS/TS semgrep rules are still relevant.
You can try running the following to see it in action:
Note that I'm forced to exclude some rules relying on NPM's API to run since in the case of github actions there's no actual package released to NPM.