-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tcp.current_established/tcp.connections metric types #18764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Neale
previously approved these changes
Oct 3, 2024
JakeYankovich
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! thanks
julien-lebot
approved these changes
Oct 4, 2024
Kyle-Neale
approved these changes
Oct 4, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.58.x 7.58.x
# Navigate to the new working tree
cd .worktrees/backport-7.58.x
# Create a new branch
git switch --create backport-18764-to-7.58.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 990cc9bec8bb1a4b5b89bcdeca3118b24776488f
# Push it to GitHub
git push --set-upstream origin backport-18764-to-7.58.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.58.x Then, create a pull request where the |
datadog-agent-integrations-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
(cherry picked from commit 990cc9b)
4 tasks
Kyle-Neale
pushed a commit
that referenced
this pull request
Oct 4, 2024
…8769) (cherry picked from commit 990cc9b) Co-authored-by: Branden Clark <[email protected]>
HadhemiDD
pushed a commit
that referenced
this pull request
Oct 7, 2024
…8769) (cherry picked from commit 990cc9b) Co-authored-by: Branden Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Send
tcp.current_established
/tcp.connections
as gauge instead of rate/countadds tests for metric types
Motivation
https://datadoghq.atlassian.net/browse/WINA-1086
metrics added in #18294 but this case was missed
Additional Notes
no changelog b/c it's a fix for something not yet released (to be released in 7.58
this bug creates
INFO
logs of the formReview checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged