Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][Flink Jar]Fix FLINK JAR submission #4073

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

zackyoungh
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit de3aeed into DataLinkDC:1.2 Dec 22, 2024
@zackyoungh zackyoungh deleted the fix_flink_jar_sql branch December 23, 2024 01:45
@jiangwwwei
Copy link

image
args should not directly use the pretreatStatement() method because it will interpret everything from "--" onwards in args as comments and clear it.

for example:
String args="--key1 value1 --key 2 value2" ;
pretreatStatement(args) -> ""

It is recommended to replace variables directly using getVariableManager().parseVariable(args).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
3 participants