-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish Security Resprite #1197
Finish Security Resprite #1197
Conversation
The long-awaited second half should make Delta-V security almost fully distinct from WizDen.
RSI Diff Bot; head commit fc6c249 merging into 0976829 Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/brigmedic.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/centcom_officer.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/hopmesskit.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/hos.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/hos_blue.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/hos_grey.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/security.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/security_blue.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/security_grey.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/warden.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/warden_blue.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/warden_grey.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/brigmedic.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/hopmesskit.rsi
Resources/Textures/DeltaV/Clothing/Head/Hats/beret_det.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/Coats/labcoat_corpsman.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/WinterCoats/coatdet.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/WinterCoats/coathos.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/WinterCoats/coatsec.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/WinterCoats/coatwarden.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/detective.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/secformal.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/detective.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/security_cadet.rsi
Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/security_tactical.rsi
|
Does this include the senior officer gear coming up in the loadouts merge? |
ehh? fuck's with the central package version manager?? |
It does include senior officer gear, which will need to be incorporated into the loadouts merge. When this PR goes through I'll address security's loadouts. |
wizden issue, if you see all the items appear in game it's a good sign |
Well, I can give you the classic "works on my machine lol" |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
winning a little too hard today |
Remove jumpskirt issue? Signed-off-by: Tad "Taddy" Johnson <[email protected]>
More wizden based issues? |
Yep, looks like they're the same errors as on the vulp overlay removal. Works fine on my machine. Sooner this gets merged, sooner I can fix other parts of the loadout system (mostly deprecated wizden items being used instead of delta-v items) |
Just let me know if this needs discussion or changes prior to merge, I can address both as necessary. |
This will be reviewed when someone gets to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yaml changes seem fine so far, I'll do a more in depth review in a few days if no other maintainer gets it done first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look at this even though it's closed (AND!! I'm not a maintainer, just some random fucking contrib), most of the changes themselves are to sprites and YML files. This is good to merge as it appears on the surface and most of the new files it introduces and integrates, AND changes are sprites. You are free to un-close it and merge it.
One thing that I will note is it does get rid of the detective clothes and greatcoat as gear from the DetDrobe and SecDrobe as an option in favor of the Forensic Specialist gear added in this PR, so if anyone wants them back there, they'll have to add them alongside the stuff here.
Trench coats + noir suits + fedoras were intended to be removed in favour of detectives having actual uniforms that make sense. As for the greatcoat, it's still in the sec drobe, just locked behind the manager wire. |
at least keep the old det stuff for loadouts :( its fun |
If it was possible to sign comments on GitHub mine would be "TJ, Antithesis of Fun" |
Why was this closed? Is it still going to be reviewed? |
If this isn't reopened by the time I get around to it, I'll just open a new PR from the same branch. This change does need to get merged eventually, having it closed contributes nothing. |
The long-awaited second half should make Delta-V security almost fully distinct from WizDen.
About the PR
Finished respriting security, including detective, warden, cadets, senior officers - etc.
Why / Balance
Was always intended from the first resprite, in an attempt to make Delta-V security more visually distinct, interesting, and g r i t t i e r.
Some mild changes to balance with the coats, other than that should all be normal.
Technical details
Media
Breaking changes
Changelog
🆑 TJohnson