Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sec Shades Returns to Staff #626

Closed
wants to merge 9 commits into from

Conversation

ps3moira
Copy link
Contributor

@ps3moira ps3moira commented Dec 31, 2023

About the PR

Sec shades are given back to Security Officers, Warden, and HoS.

Why / Balance

Locking sec shades behind tier 2 research made it so Sec was doomed to never have them again.

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame

Changelog
🆑

  • add: Added sec sunglasses to security officers, warden, and head of security.

@@ -49,7 +49,7 @@
- id: RubberStampWarden
- id: DoorRemoteArmory
- id: HoloprojectorSecurity
- id: ClothingEyesHudSecurity
- id: ClothingEyesHudSecurity #Delta-V: Sechud Scarcity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what exactly is getting changed besides the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally, I had it removed. It ended up causing some issues and I'm currently working on trying to fix it.

@@ -92,7 +92,7 @@
- id: ClothingShoesBootsJack
- id: WeaponMeleeNeedle
prob: 0.1
- id: ClothingEyesHudSecurity
- id: ClothingEyesHudSecurity #Delta-V: Sechud Scarcity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same deal here

@@ -50,7 +50,8 @@
back: ClothingBackpackHOSFilled
shoes: ClothingShoesBootsCombatFilled
outerClothing: ClothingOuterCoatHoSTrench
eyes: ClothingEyesGlassesSunglasses
eyes: ClothingEyesGlassesSecurity # Delta-V: Replaced Regular Sunglasses
# eyes: ClothingEyesGlassesSunglasses # Delta-V: Replaced
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just replace the entire line and say you replaced it, this doesnt help

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict Fix your PR! label Jan 28, 2024
@DebugOk
Copy link
Contributor

DebugOk commented Feb 12, 2024

This pr may be closed if it stays derelict

@DebugOk DebugOk added the Status: Derelict Has not been active for a while label Feb 12, 2024
@VMSolidus
Copy link
Contributor

I'm going to close this PR as unecessary. In practice Security gets the Sec Shades in nearly every round, since they're cheap to make, good wardens get on top of making them, and Epi tends to prioritize early security research so that they can take advantage of Oracle's ~50% chance of asking for Security techfab stuff.

@VMSolidus VMSolidus closed this Mar 8, 2024
@VMSolidus VMSolidus mentioned this pull request Mar 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Status: Derelict Has not been active for a while Status: Merge Conflict Fix your PR! Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants