Create constant infiltration rates based on lulc and reclass_table #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirkEilander
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Thanks @roeldegoede for this PR!
I've made a few small changes (see also comments), let me know if you agree.
It would be good to also update the csv tables - can you still do that?
Otherwise good to be merged.
hydromt_sfincs/sfincs.py
Outdated
| elif lulc is not None: | ||
| # landuse/landcover should always be combined with mapping | ||
| if reclass_table is None and isinstance(lulc, str): | ||
| reclass_table = join(DATADIR, "qinf", f"{lulc}_mapping.csv") |
There was a problem hiding this comment.
I changed this to point the the "data/lulc" folder. Should we also modify the tables in there to contain a qinf column?
hydromt_sfincs/sfincs.py
Outdated
Comment on lines
980
to
984
| if ( | ||
| not os.path.isfile(reclass_table) | ||
| and reclass_table not in self.data_catalog | ||
| ): | ||
| raise IOError(f"Infiltration mapping file not found: {reclass_table}") |
There was a problem hiding this comment.
This doesn't work if reclass_table is a pandas DataFrame
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the existing functionality, we can now also set up constant infiltration rates based on landuse/landcover and a reclass table. Before we could only use spatiallly varying infiltration fields.