-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade toml-edit crate #78
Conversation
Hi @jplatte , I have upgraded the toml-edit crate, please review it. |
Hi, could you please make the CI changes their own separate PR and write some words on the why of that change (either as part of the commit message, or the PR description)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, why did you delete a bunch of settings from the rustfmt config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the deleted items can not pass the nightly CI.
I noticed that when you released the version, it failed. I checked the usage of the components used by the script and modified them accordingly.
|
There's still too many changes mixed in this one PR. This is a pretty low-priority project to me, otherwise I would have split the PR up myself probably. |
And finished PR: #81 |
No description provided.