Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade toml-edit crate #78

Closed
wants to merge 2 commits into from
Closed

Upgrade toml-edit crate #78

wants to merge 2 commits into from

Conversation

ssrlive
Copy link
Contributor

@ssrlive ssrlive commented Oct 20, 2024

No description provided.

@ssrlive
Copy link
Contributor Author

ssrlive commented Oct 20, 2024

Hi @jplatte , I have upgraded the toml-edit crate, please review it.

@jplatte
Copy link
Collaborator

jplatte commented Oct 20, 2024

Hi, could you please make the CI changes their own separate PR and write some words on the why of that change (either as part of the commit message, or the PR description)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why did you delete a bunch of settings from the rustfmt config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the deleted items can not pass the nightly CI.

@ssrlive
Copy link
Contributor Author

ssrlive commented Oct 20, 2024

I noticed that when you released the version, it failed. I checked the usage of the components used by the script and modified them accordingly.

Hi, could you please make the CI changes their own separate PR and write some words on the why of that change (either as part of the commit message, or the PR description)?

@ssrlive
Copy link
Contributor Author

ssrlive commented Oct 20, 2024

I have test it just now. It's can release the packages correctly. I have so many other jobs. I hope you won't make things difficult for me.

image

@ikrivosheev
Copy link
Contributor

@jplatte @ssrlive any updates?

@jplatte
Copy link
Collaborator

jplatte commented Nov 19, 2024

There's still too many changes mixed in this one PR. This is a pretty low-priority project to me, otherwise I would have split the PR up myself probably.

@ikrivosheev ikrivosheev mentioned this pull request Nov 19, 2024
2 tasks
@ikrivosheev
Copy link
Contributor

ikrivosheev commented Nov 19, 2024

@jplatte I started splitting this MR into parts.

CI: #79
Clippy&Rustfmt: #80

@ikrivosheev ikrivosheev mentioned this pull request Nov 19, 2024
@ikrivosheev
Copy link
Contributor

And finished PR: #81

@jplatte jplatte closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants