feat(agent): Devolutions agent bootstrap #875
Conversation
pacmancoder
force-pushed
the
devolutions-agent
branch
from
269a4af
to
35a87bd
Compare
| pub trait StaticLogConfig { | ||
| const MAX_BYTES_PER_LOG_FILE: u64; | ||
| const MAX_LOG_FILES: usize; | ||
| const LOG_FILE_PREFIX: &'static str; | ||
| } |
There was a problem hiding this comment.
Only change in this file after move is making some logging parameters generic via trait
| /// Unstable options are subject to change | ||
| #[derive(PartialEq, Debug, Clone, Serialize, Deserialize)] | ||
| #[serde(rename_all = "PascalCase")] | ||
| pub struct ConfFile { |
There was a problem hiding this comment.
Copied from Gateway, kept only fields for logging
| let subcommand = env::args().nth(2).expect("missing config subcommand"); | ||
| if let Err(e) = config::handle_cli(subcommand.as_str()) { | ||
| eprintln!("[ERROR] Agent configuration failed: {}", e); | ||
| } |
There was a problem hiding this comment.
simple config initialization logic to call from MSI
| @@ -0,0 +1,251 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Service, WinAPI, and other helpers (which were copied without change except namespace from Gateway) could be refactored and moved to a separate "Common" project to share between Agent and Gateway, but I think this could be done as a follow-up
|
|
||
| internal static IEnumerable<Type> Dialogs => Sequence; | ||
|
|
||
| internal static int Move(IManagedDialog current, bool forward) |
There was a problem hiding this comment.
removed (currently not required) configuration logic.
There was a problem hiding this comment.
I haven't had much experience with PowerShell still, @awakecoding please take a look at these changes 👀
In short -- I have added new -Product <product> parameter to tlk.ps1 and added code to build/package Devolutions Agent on Windows & Linux
There was a problem hiding this comment.
Mostly copied from Gateway, removed all tasks except log deleter
There was a problem hiding this comment.
Kept only minimal amount of actions, removed everything gateway-related
There was a problem hiding this comment.
All dialog logic were kept unchanged (only strings changed)
There was a problem hiding this comment.
I am not a designer by any means, but I made temporary changes to icon/banners just to easily distinguish between gateway and agent installers
There was a problem hiding this comment.
question: Are you sure we need a separate .gitignore in this folder? target/ and Cargo.lock is supposed to be shared with the rest of the workspace.
There was a problem hiding this comment.
Thanks, it indeed should be removed 👍
| # devolutions-log | ||
| Common code for logging in devolutions apps |
There was a problem hiding this comment.
nitpick: Sorry for repeating myself, but to strictly it’s only for the services provided in this repository, and we do have other services that this crate is not supposed to be used for. A different wording could be used. But not really a big deal.
There was a problem hiding this comment.
Very good job!! I think it’s looking good so I’ll approve. But it could be nice to wait for input from @thenextman on the installer. Also, you probably want to remove the extra .gitignore which was likely committed by accident.
|
@thenextman Could you please skim over the MSI code? |
| /// BUILTIN\Administrators Allow FullControl | ||
| /// BUILTIN\Users Allow ReadAndExecute, Synchronize | ||
| /// </remarks> | ||
| internal static string PROGRAM_DATA_SDDL = "O:SYG:SYD:PAI(A;OICI;FA;;;SY)(A;OICI;0x1201bf;;;LS)(A;OICI;0x1301bf;;;NS)(A;OICI;FA;;;BA)(A;OICI;0x1200a9;;;BU)"; |
There was a problem hiding this comment.
NETWORK SERVICE can be removed from the permission set here and below, I'd add a comment to point out that this differs from the Gateway install.
I found the easiest way to generate the SDDL string is to configure the permissions you want manually, then use PowerShell (Get-ACL has a SDDL property IIRC)
There was a problem hiding this comment.
I'll fix this in follow-up, thanks!
I skimmed and made a single comment, in the future it will be nice to consolidate the shared code but as you wrote: looks good for now :) Can we check that the Package.yml workflow didn't get any breaking changes before merging? |
The branch was already merged a few days ago, and the packaging task was broken and then fixed by #879 😄 |
This PR bootstraps the Devolutions Agent project.
Although this PR is huge, most of it is because of copy-paste from Devolutions Gateway MSI, so don't be discouraged -- I left comments in code where it really requires review
The overall list of changes:
devolutions-agentcratedevolutions-agenttlk.ps1now builds both Gateway and Agent-Productparameter to select product to build/packageMSI installer presentation:
2024-06-01.15-54-50.mp4