feat(agent): Devolutions Gateway service updater #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacmancoder
force-pushed
the
feat/agent-udpater
branch
from
62033c3
to
83f96e6
Compare
pacmancoder
commented
Jun 18, 2024
| /// BUILTIN\Administrators Allow FullControl | ||
| /// BUILTIN\Users Allow ReadAndExecute, Synchronize | ||
| /// </remarks> | ||
| internal static string PROGRAM_DATA_SDDL = "O:SYG:SYD:PAI(A;OICI;FA;;;SY)(A;OICI;0x1201bf;;;LS)(A;OICI;0x1301bf;;;NS)(A;OICI;FA;;;BA)(A;OICI;0x1200a9;;;BU)"; |
There was a problem hiding this comment.
Adjusted DACL as @thenextman commented here
pacmancoder
commented
Jun 18, 2024
| /// for upgrade code table. | ||
| /// | ||
| /// e.g.: `{82318d3c-811f-4d5d-9a82-b7c31b076755}` => `C3D81328F118D5D4A9287B3CB1707655` | ||
| pub fn uuid_to_reversed_hex(uuid: &str) -> Result<String, UpdaterError> { |
There was a problem hiding this comment.
Windows UUIDs are weird 😄
pacmancoder
commented
Jun 18, 2024
| use crate::updater::{Product, UpdaterCtx, UpdaterError}; | ||
|
|
||
| /// List of allowed thumbprints for Devolutions code signing certificates | ||
| const DEVOLUTIONS_CERT_THUMBPRINTS: &[&str] = &[ |
There was a problem hiding this comment.
Allowed devolutions certs thumbprints which @awakecoding shared with me
CBenoit
changed the title
CBenoit
reviewed
Jun 18, 2024
CBenoit
reviewed
Jun 18, 2024
Comment on lines
+128
to
+130
| /// Enable updater module (enabled by default) | ||
| #[serde(default)] | ||
| pub disable: bool, |
There was a problem hiding this comment.
suggestion: I think it would be better the other way around. You override the default value to "true" if that’s what you want.
Suggested change
| /// Enable updater module (enabled by default) | |
| #[serde(default)] | |
| pub disable: bool, | |
| /// Enable updater module (enabled by default) | |
| #[serde(default = "true")] | |
| pub enabled: bool, |
CBenoit
reviewed
Jun 18, 2024
CBenoit
reviewed
Jun 18, 2024
CBenoit
reviewed
Jun 18, 2024
CBenoit
reviewed
Jun 18, 2024
CBenoit
reviewed
Jun 18, 2024
CBenoit
reviewed
Jun 18, 2024
CBenoit
reviewed
Jun 18, 2024
awakecoding
approved these changes
Jun 20, 2024
CBenoit
added a commit
that referenced
this pull request
Jun 21, 2024
CBenoit
added a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Gateway updater logic in
devolutions-agent.This update mechanism is triggered by changing
ProgramData/Devolutions/Agent/update.jsonfile, setting the required version to update the gateway.Example
update.json:{ "Gateway": { "TargetVersion": "2024.2.1" } }Features:
update.jsonis created on first service start, and correct DACL is set to allowNT AUTHORITY/Network Service(which is used by Gateway) to edit this file