Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace libdparse in AsmStyleCheck #75

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

Vladiwostok
Copy link
Collaborator

@Vladiwostok Vladiwostok commented Oct 30, 2023

This check targets confusing asm code when it comes to addressing memory:
mov eax, ebx[1]
This is confusing as it looks like an array index, the proper code would be:
mov eax, [ebx + 1]

@RazvanN7
Copy link
Collaborator

This PR seems to do multiple things:

  1. Implement a check
  2. Do some white space prunning
  3. Fix a bug with regards to null terminated strings.

Might be other things, but those are just identified at a first glance.

To ease the review process, please split any independent parts into multiple PRs.
That makes it easier to identify regressions and to review a PR.

@RazvanN7 RazvanN7 merged commit 2b7d5ec into Dlang-UPB:replace_libdparse Nov 7, 2023
11 of 13 checks passed
@Vladiwostok Vladiwostok deleted the asm_style branch November 7, 2023 09:17
edi33416 pushed a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants