Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete DuplicateAttributeCheck #79

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Delete DuplicateAttributeCheck #79

merged 1 commit into from
Feb 22, 2024

Conversation

Vladiwostok
Copy link
Collaborator

#72 cont

@Vladiwostok Vladiwostok changed the title delete duplicate_attribute visitor Delete DuplicateAttributeCheck Nov 12, 2023
RazvanN7
RazvanN7 requested changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry explaining why this feature is deleted (i.e. because the compiler now errors on this sort of code).

@Vladiwostok
Copy link
Collaborator Author

Please add a changelog entry explaining why this feature is deleted (i.e. because the compiler now errors on this sort of code).

There is a changelog entry:
https://github.com/Dlang-UPB/D-scanner/pull/79/files#diff-6e46c28e9caccd279528d24aaa42cbbf626bbe6b4bf4bc79de5a6fe3c68d33ef

Is this not enough?

@RazvanN7 RazvanN7 merged commit 4301f6a into Dlang-UPB:replace_libdparse Feb 22, 2024
19 checks passed
@Vladiwostok Vladiwostok deleted the delete-duplicateda branch August 6, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvanN7 RazvanN7 RazvanN7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vladiwostok @RazvanN7