Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set correct height for tabs #854

Merged
merged 3 commits into from
Dec 14, 2024
Merged

fix: Set correct height for tabs #854

merged 3 commits into from
Dec 14, 2024

Conversation

frankieyan
Copy link
Member

@frankieyan frankieyan commented Dec 14, 2024

Short description

Following up from #851, this adds top/bottom paddings to the tabs so that they render at the same height as before the line-height change. Paddings are used over min-height so that they remain consistent even if multiple lines of text are rendered in the tabs.

Before After
image image
image image

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Patch

@frankieyan frankieyan requested a review from henningmu December 14, 2024 05:00
@frankieyan frankieyan merged commit 3594542 into main Dec 14, 2024
5 checks passed
@frankieyan frankieyan deleted the frankie/fix-tab-height branch December 14, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant